updated workflow to push multi-arch image for s390x#86
Closed
modassarrana89 wants to merge 1 commit intoopendatahub-io:mainfrom
Closed
updated workflow to push multi-arch image for s390x#86modassarrana89 wants to merge 1 commit intoopendatahub-io:mainfrom
modassarrana89 wants to merge 1 commit intoopendatahub-io:mainfrom
Conversation
Author
|
@ruivieira @goern Please review the changes |
Member
Author
dhirajsb
requested changes
Apr 15, 2024
Contributor
dhirajsb
left a comment
There was a problem hiding this comment.
@modassarrana89 please update the PR to use the shell script build_deploy.sh to push images for the platforms. We would like to keep the gh actions simple and keep product details like supported platforms in the shell scripts instead.
Also, this PR drops the main-commit docker tag as well for some reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated build and push github workflow with qemu action to build & push multi-arch image
How Has This Been Tested?
Workflow has been executed and able to push multi-arch image on local registry
Tested on local environment by deploying in local environment