Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated image manifests with AMD images for pytorch and tensorflow #593

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Updated image manifests with AMD images for pytorch and tensorflow #593

merged 1 commit into from
Aug 18, 2024

Conversation

dibryant
Copy link
Contributor

@dibryant dibryant commented Jun 26, 2024 •
edited
Loading

Fixes for https://issues.redhat.com/browse/RHOAIENG-4368

Description

Updated imagestream for AMD pytorch and tensorflow for users that want OOTB workbench images with AMD libraries & package

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from jiridanek and jstourac June 26, 2024 19:13
@atheo89
Copy link
Member

atheo89 commented Jun 27, 2024

/hold till this get merged #557

atheo89
atheo89 requested changes Jun 27, 2024
View reviewed changes
Copy link
Member

@atheo89 atheo89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I left some comments!

manifests/overlays/additional/jupyter-amd-pytorch-notebook-imagestream.yaml Outdated Show resolved Hide resolved
manifests/overlays/additional/jupyter-amd-tensorflow-notebook-imagestream.yaml Outdated Show resolved Hide resolved
manifests/overlays/additional/jupyter-amd-pytorch-notebook-imagestream.yaml Outdated Show resolved Hide resolved
@dibryant
Copy link
Contributor Author

/retest

@dibryant dibryant changed the title Updated image manifests with AMD images for pytorch and tensorflow WIP Updated image manifests with AMD images for pytorch and tensorflow Jul 24, 2024
@dibryant
Copy link
Contributor Author

/retest-required

harshad16
harshad16 requested changes Jul 31, 2024
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as we are not yet ready to release this images
probably it would be best to get ready.

we need to move this to base:

without changing the kustomization.yaml, so we don't have them deployed.

Examples:

harshad16
harshad16 requested changes Aug 2, 2024
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, some changes are needed

manifests/base/commit.env Outdated Show resolved Hide resolved
manifests/base/commit.env Outdated Show resolved Hide resolved
manifests/base/commit.yaml Show resolved Hide resolved
manifests/base/jupyter-rocm-tensorflow-notebook-imagestream.yaml Outdated Show resolved Hide resolved
manifests/base/jupyter-rocm-tensorflow-notebook-imagestream.yaml Outdated Show resolved Hide resolved
manifests/base/params.env Outdated Show resolved Hide resolved
manifests/base/params.yaml Outdated Show resolved Hide resolved
@dibryant dibryant force-pushed the amd-is branch 2 times, most recently from 3e32e2c to 8694c69 Compare August 7, 2024 04:00
@dibryant dibryant force-pushed the amd-is branch 5 times, most recently from 280719f to 3beba31 Compare August 12, 2024 13:44
@dibryant dibryant force-pushed the amd-is branch 2 times, most recently from 9d95d9a to cc8572b Compare August 12, 2024 14:02
atheo89
atheo89 requested changes Aug 12, 2024
View reviewed changes
Copy link
Member

@atheo89 atheo89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes needed

manifests/base/commit.env Outdated Show resolved Hide resolved
manifests/base/jupyter-rocm-pytorch-notebook-imagestream.yaml Outdated Show resolved Hide resolved
manifests/base/params.env Outdated Show resolved Hide resolved
@dibryant dibryant force-pushed the amd-is branch 4 times, most recently from 1dcb3e1 to 3eb30b6 Compare August 12, 2024 19:21
@dibryant dibryant changed the title WIP Updated image manifests with AMD images for pytorch and tensorflow Updated image manifests with AMD images for pytorch and tensorflow Aug 12, 2024
harshad16
harshad16 requested changes Aug 14, 2024
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For fixing the validation check, i believe following changes are needed
PTAL

ci/check-params-env.sh Outdated Show resolved Hide resolved
ci/check-params-env.sh Outdated Show resolved Hide resolved
ci/check-params-env.sh Outdated Show resolved Hide resolved
ci/check-params-env.sh Outdated Show resolved Hide resolved
manifests/base/params.env Outdated Show resolved Hide resolved
manifests/base/commit.env Outdated Show resolved Hide resolved
@dibryant dibryant force-pushed the amd-is branch 8 times, most recently from f706ef5 to 87ad31a Compare August 16, 2024 16:31
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 16, 2024 •
edited
Loading

@dibryant: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/amd-runtimes-ubi9-e2e-tests 9e9d838 link true /test amd-runtimes-ubi9-e2e-tests
ci/prow/notebook-rocm-ubi9-python-3-9-pr-image-mirror 9e9d838 link true /test notebook-rocm-ubi9-python-3-9-pr-image-mirror
ci/prow/runtime-rocm-pytorch-ubi9-python-3-9-pr-image-mirror 9e9d838 link true /test runtime-rocm-pytorch-ubi9-python-3-9-pr-image-mirror
ci/prow/runtime-rocm-tensorflow-ubi9-python-3-9-pr-image-mirror 9e9d838 link true /test runtime-rocm-tensorflow-ubi9-python-3-9-pr-image-mirror
ci/prow/runtimes-ubi8-e2e-tests 9e9d838 link true /test runtimes-ubi8-e2e-tests
ci/prow/runtimes-ubi9-e2e-tests 9e9d838 link true /test runtimes-ubi9-e2e-tests
ci/prow/rocm-runtimes-ubi9-e2e-tests 9e9d838 link true /test rocm-runtimes-ubi9-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

harshad16
harshad16 approved these changes Aug 18, 2024
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks 👍

@openshift-ci openshift-ci bot added the lgtm label Aug 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek
Copy link
Member

/override ci/prow/rocm-notebooks-e2e-tests

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 18, 2024

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/rocm-notebooks-e2e-tests

In response to this:

/override ci/prow/rocm-notebooks-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 5573f26 into opendatahub-io:main Aug 18, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstourac jstourac jstourac left review comments

@jiridanek jiridanek jiridanek left review comments

@atheo89 atheo89 atheo89 requested changes

@harshad16 harshad16 harshad16 approved these changes

Assignees

@harshad16 harshad16

@atheo89 atheo89

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dibryant @atheo89 @jiridanek @jstourac @harshad16 @openshift-merge-robot