RHOAIENG-11274: chore(Makefile): widen the container build context to the whole repo, so we can start reusing code between images in the future #792
Conversation
|
Skipping CI for Draft Pull Request. |
jiridanek
force-pushed
the
jd_restructure_variable
branch
5 times, most recently
from
b6b79e0 to
428bc83
Compare
… the whole repo, so we can start reusing code between images in the future
```python
import glob
import pathlib
def main():
for dockerfile in glob.glob("**/Dockerfile", recursive=True):
print(dockerfile)
path = pathlib.Path(dockerfile)
lines = path.read_text().splitlines()
idx = lines.index("ARG SOURCE_CODE=.")
lines[idx] = f"ARG SOURCE_CODE={str(path.parent)}"
print("\t", lines[idx])
path.write_text("\n".join(lines) + "\n")
if __name__ == '__main__':
main()
```
…ve time when initializing builds
jiridanek
force-pushed
the
jd_restructure_variable
branch
from
428bc83 to
36abe11
Compare
jiridanek
added
the
tide/merge-method-squash
…xt to the whole repo, so we can start reusing code between images in the future Relates to * opendatahub-io/notebooks#792
|
/testwith openshift/release/master/notebook-codeserver-ubi9-python-3-11-pr-image-mirror openshift/release#59520 #792 |
|
@jiridanek, |
|
/testwith jiridanek/release/jd_change_context/notebook-codeserver-ubi9-python-3-11-pr-image-mirror openshift/release#59520 #792 |
|
@jiridanek, |
|
/testwith openshift/release/master/notebook-codeserver-ubi9-python-3-11-pr-image-mirror openshift/release#59520 #792 |
|
@jiridanek, |
|
pushed it back to what has been lgtmd 
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
|
/override build (cuda-jupyter-tensorflow-ubi9-python-3.11) |
This comment has been minimized.
This comment has been minimized.
|
/override "build (cuda-jupyter-tensorflow-ubi9-python-3.11) / build" Failures tracked in https://issues.redhat.com/browse/RHOAIENG-16587 |
|
@jiridanek: Overrode contexts on behalf of jiridanek: build (cuda-jupyter-tensorflow-ubi9-python-3.11) / build, build (rocm-jupyter-pytorch-ubi9-python-3.9) / build, build (rocm-jupyter-tensorflow-ubi9-python-3.11) / build In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest-required |
|
/test codeserver-notebook-e2e-tests |
2 similar comments
|
/test codeserver-notebook-e2e-tests |
|
/test codeserver-notebook-e2e-tests |
|
/override multi-pr-opendatahub-io-notebooks-792-openshift-release-59520-notebook-cuda-jupyter-min-ubi9-python-3-11-pr-image-mirror |
|
@jiridanek: Overrode contexts on behalf of jiridanek: multi-pr-opendatahub-io-notebooks-792-openshift-release-59520-notebook-cuda-jupyter-min-ubi9-python-3-11-pr-image-mirror In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override multi-pr-opendatahub-io-notebooks-792-openshift-release-59520-runtime-minimal-ubi9-python-3-9-pr-image-mirror these multi-pr checks don't work for testing build configs updates in openshift/release |
|
@jiridanek: Overrode contexts on behalf of jiridanek: multi-pr-opendatahub-io-notebooks-792-openshift-release-59520-runtime-minimal-ubi9-python-3-11-pr-image-mirror, multi-pr-opendatahub-io-notebooks-792-openshift-release-59520-runtime-minimal-ubi9-python-3-9-pr-image-mirror In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "build / (cuda-jupyter-tensorflow-ubi9-python-3.11)" |
This comment was marked as outdated.
This comment was marked as outdated.
|
/retest-required |
|
Can't ever get all images to build, so OCP-CI tests don't run
/override ci/prow/rocm-runtimes-ubi9-e2e-tests ci/prow/rocm-notebooks-e2e-tests ci/prow/notebooks-ubi9-e2e-tests |
|
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/codeserver-notebook-e2e-tests, ci/prow/notebooks-ubi9-e2e-tests, ci/prow/rocm-notebooks-e2e-tests, ci/prow/rocm-runtimes-ubi9-e2e-tests, ci/prow/rstudio-notebook-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/intel-notebooks-e2e-tests ci/prow/runtimes-ubi9-e2e-tests |
|
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/intel-notebooks-e2e-tests, ci/prow/runtimes-ubi9-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 03c3b6f
into
opendatahub-io:main
…xt to the whole repo, so we can start reusing code between images in the future (openshift#59520) * run `make ci-operator-config` to make prow happy * fix dockerfile_path to be relative * fix context_dir to be . Relates to * opendatahub-io/notebooks#792
…xt to the whole repo, so we can start reusing code between images in the future (openshift#59520) * run `make ci-operator-config` to make prow happy * fix dockerfile_path to be relative * fix context_dir to be . Relates to * opendatahub-io/notebooks#792
https://issues.redhat.com/browse/RHOAIENG-11274
Description
TODOs
How Has This Been Tested?
GHA on my fork
Merge criteria: