RHOAIENG-16403: chore(Makefile): remove the now-unnecessary trailing slash (\s*;?\s*\\$)
#808
Conversation
I wanted to ignore this until we switch to `>`, but it actually started causing CI build failures right now, so it must be fixed after all.
jiridanek
added
the
tide/merge-method-squash
| @@ -14,7 +14,7 @@ MAKEFLAGS += --no-builtin-rules | |||
|
|
|||
| # todo: leave the default recipe prefix for now | |||
| ifeq ($(origin .RECIPEPREFIX), undefined) | |||
| $(error This Make does not support .RECIPEPREFIX. Please use GNU Make 4.0 or later) | |||
| $(error This Make does not support .RECIPEPREFIX. Please use GNU Make 4.0 or later) | |||
There was a problem hiding this comment.
Yes, completely deliberate.
This PR ended up with indenting everything with tabs (🎉), except for this single line (😢). This one can't be indented with tabs, because that would cause syntax error
Makefile:17: *** commands commence before first target. Stop.
The only way to achieve consistent indentation in the whole file is to not indent line 17.
|
/lgtm |
|
/lgtm /override ci/prow/images |
|
@jstourac: Overrode contexts on behalf of jstourac: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve i went over the diff again, still looks good to me, giving it approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…slash (`\s*;?\s*\\$`) (opendatahub-io#808) * RHOAIENG-16403: chore(Makefile): remove the now-unnecessary trailing `\s*;?\s*\\$` * fix some wrongly indented lines I wanted to ignore this until we switch to `>`, but it actually started causing CI build failures right now, so it must be fixed after all.
https://issues.redhat.com/browse/RHOAIENG-16403
Follow-up to
.ONESHELL:and.SHELLFLAGS := -eu -o pipefail -cin Makefile #791Description
We're able to remove the unnecessary continuation lines from the Makefile, now that the recipe body is running in a single shell.
How Has This Been Tested?
Merge criteria: