Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2024a] Cherry-pick: RHOAIENG-15393: update piplock renewal gh action #815

Merged
merged 4 commits into from
Dec 19, 2024
Merged

[2024a] Cherry-pick: RHOAIENG-15393: update piplock renewal gh action #815

merged 4 commits into from
Dec 19, 2024

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Dec 18, 2024 •
edited
Loading

https://issues.redhat.com/browse/RHOAIENG-15393

Description

Brings the ca80fee change to 2024a branch.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

atheo89 and others added 2 commits December 18, 2024 19:05
@atheo89 @jiridanek
Update piplock renewal gh action
a6850a3 
Remove old obsolete files

Include codeserver notebook on the refresh-piplock-files recipe

Update refresh-pipfilelock-files to accept optional file directories for updates

Update documentation in regards the Pipfile lock generation

(cherry picked from commit ca80fee)
@jiridanek
fixup proper 2024a paths and python versions
4c9e6bc
@openshift-ci openshift-ci bot requested review from caponetto and dibryant December 18, 2024 18:13
@jiridanek jiridanek added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 18, 2024
@jiridanek jiridanek changed the title [2024a] Cherry-pick: Update piplock renewal gh action [2024a] Cherry-pick: RHOAIENG-15393: update piplock renewal gh action Dec 18, 2024
@jiridanek
Copy link
Member Author

/override ci/prow/images
not relevant for the PR

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to this:

/override ci/prow/images
not relevant for the PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member Author

/override ci/prow/images
not relevant for the PR

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to this:

/override ci/prow/images
not relevant for the PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@atheo89
Copy link
Member

atheo89 commented Dec 19, 2024

Thank you Jiri! 🙂
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 19, 2024
jiridanek
jiridanek commented Dec 19, 2024
View reviewed changes
.github/workflows/piplock-renewal.yaml
Comment on lines +7 to +14
schedule:
- cron: "0 22 * * 1"
workflow_dispatch: # for manual trigger workflow from GH Web UI
inputs:
branch:
description: 'Specify branch'
required: false
default: 'main'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm wondering if I need to edit this as well; I'll watch it and if it's necessary to make edits will make them later

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, we should update it and probably disable the cron

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#820

@jiridanek
Copy link
Member Author

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3dd9f34 into opendatahub-io:2024a Dec 19, 2024
7 checks passed
@jiridanek jiridanek deleted the jd_2024again branch December 19, 2024 10:58
@atheo89 atheo89 mentioned this pull request Dec 19, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atheo89 atheo89 atheo89 left review comments

@caponetto caponetto Awaiting requested review from caponetto

@dibryant dibryant Awaiting requested review from dibryant

Assignees

@atheo89 atheo89

Labels
approved lgtm tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiridanek @atheo89