Skip to content

Commit

Permalink
ImagePullBackOff is not handled as error during workbench start
Browse files Browse the repository at this point in the history
  • Loading branch information
dpanshug committed Sep 27, 2024
1 parent 947c09b commit 0390bef
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions frontend/src/pages/projects/notebook/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,9 @@ export const useNotebookStatus = (
if (!gracePeriod && lastItem.reason === 'FailedScheduling') {
currentEvent = 'Insufficient resources to start';
status = EventStatus.ERROR;
} else if (!gracePeriod && lastItem.reason === 'BackOff') {
currentEvent = 'ImagePullBackOff';
status = EventStatus.ERROR;

Check warning on line 244 in frontend/src/pages/projects/notebook/utils.ts

View check run for this annotation

Codecov / codecov/patch

frontend/src/pages/projects/notebook/utils.ts#L242-L244

Added lines #L242 - L244 were not covered by tests
} else if (lastItem.type === 'Warning') {
currentEvent = 'Issue creating notebook container';
status = EventStatus.WARNING;
Expand Down
3 changes: 3 additions & 0 deletions frontend/src/utilities/notebookControllerUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,9 @@ export const useNotebookStatus = (
if (!gracePeriod && lastItem.reason === 'FailedScheduling') {
currentEvent = 'Insufficient resources to start';
status = EventStatus.ERROR;
} else if (!gracePeriod && lastItem.reason === 'BackOff') {
currentEvent = 'ImagePullBackOff';
status = EventStatus.ERROR;

Check warning on line 440 in frontend/src/utilities/notebookControllerUtils.ts

View check run for this annotation

Codecov / codecov/patch

frontend/src/utilities/notebookControllerUtils.ts#L438-L440

Added lines #L438 - L440 were not covered by tests
} else if (lastItem.type === 'Warning') {
currentEvent = 'Issue creating notebook container';
status = EventStatus.WARNING;
Expand Down

0 comments on commit 0390bef

Please sign in to comment.