fix lint issue

opendatahub-io · Jul 6, 2023 · 166f12b · 166f12b
1 parent eb89255
commit 166f12b
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 11 deletions.
diff --git a/frontend/src/concepts/pipelines/content/tables/pipeline/PipelinesTable.tsx b/frontend/src/concepts/pipelines/content/tables/pipeline/PipelinesTable.tsx
@@ -6,7 +6,8 @@ import PipelinesTableRow from '~/concepts/pipelines/content/tables/pipeline/Pipe
 import { FetchStateRefreshPromise } from '~/utilities/useFetchState';
 import { pipelineColumns } from '~/concepts/pipelines/content/tables/columns';
 import DeletePipelineCoreResourceModal from '~/concepts/pipelines/content/DeletePipelineCoreResourceModal';
-import { sortByCreatedAt } from '~/utilities/sortByCreatedAt';
+import { sortRunsByCreated } from '~/concepts/pipelines/content/tables/utils';
+
 type PipelinesTableProps = {
   pipelines: PipelineKF[];
   pipelineDetailsPath: (namespace: string, id: string) => string;
@@ -29,7 +30,7 @@ const PipelinesTable: React.FC<PipelinesTableProps> = ({
   return (
     <>
       <Table
-        data={sortByCreatedAt(pipelines)}
+        data={sortRunsByCreated(pipelines)}
         enablePagination
         minPageSize={5}
         {...tableProps}

diff --git a/frontend/src/concepts/pipelines/content/tables/pipelineRun/PipelineRunTable.tsx b/frontend/src/concepts/pipelines/content/tables/pipelineRun/PipelineRunTable.tsx
@@ -11,7 +11,7 @@ import PipelineRunTableToolbar from '~/concepts/pipelines/content/tables/pipelin
 import DeletePipelineCoreResourceModal from '~/concepts/pipelines/content/DeletePipelineCoreResourceModal';
 import { usePipelinesAPI } from '~/concepts/pipelines/context';
 import useJobRelatedInformation from '~/concepts/pipelines/content/tables/pipelineRun/useJobRelatedInformation';
-import { sortByCreatedAt } from '~/utilities/sortByCreatedAt';
+import { sortRunsByCreated } from '~/concepts/pipelines/content/tables/utils';
 
 type PipelineRunTableProps = {
   runs: PipelineRunKF[];
@@ -30,7 +30,7 @@ const PipelineRunTable: React.FC<PipelineRunTableProps> = ({ runs }) => {
     <>
       <Table
         {...tableProps}
-        data={sortByCreatedAt(filteredRuns)}
+        data={sortRunsByCreated(filteredRuns)}
         columns={pipelineRunColumns}
         enablePagination
         minPageSize={5}

diff --git a/frontend/src/concepts/pipelines/content/tables/pipelineRunJob/PipelineRunJobTable.tsx b/frontend/src/concepts/pipelines/content/tables/pipelineRunJob/PipelineRunJobTable.tsx
@@ -10,7 +10,7 @@ import usePipelineRunJobFilter from '~/concepts/pipelines/content/tables/pipelin
 import EmptyTableView from '~/concepts/pipelines/content/tables/EmptyTableView';
 import DeletePipelineCoreResourceModal from '~/concepts/pipelines/content/DeletePipelineCoreResourceModal';
 import { usePipelinesAPI } from '~/concepts/pipelines/context';
-import { sortByCreatedAt } from '~/utilities/sortByCreatedAt';
+import { sortRunsByCreated } from '~/concepts/pipelines/content/tables/utils';
 
 type PipelineRunTableProps = {
   jobs: PipelineRunJobKF[];
@@ -28,7 +28,7 @@ const PipelineRunJobTable: React.FC<PipelineRunTableProps> = ({ jobs }) => {
     <>
       <Table
         {...tableProps}
-        data={sortByCreatedAt(filterJobs)}
+        data={sortRunsByCreated(filterJobs)}
         columns={pipelineRunJobColumns}
         enablePagination
         minPageSize={5}

diff --git a/frontend/src/concepts/pipelines/content/tables/utils.ts b/frontend/src/concepts/pipelines/content/tables/utils.ts
@@ -8,8 +8,10 @@ import {
 } from '~/concepts/pipelines/kfTypes';
 import { DateRangeString, splitDateRange } from '~/components/dateRange/utils';
 
-export const sortRunsByCreated = (runs: PipelineRunKF[]) =>
-  [...runs].sort((a, b) => new Date(b.created_at).getTime() - new Date(a.created_at).getTime());
+export const sortRunsByCreated = <T extends { created_at: string }>(pipelines: T[]): T[] =>
+  [...pipelines].sort(
+    (a, b) => new Date(b.created_at).getTime() - new Date(a.created_at).getTime(),
+  );
 
 export const getLastRun = (runs: PipelineRunKF[]) => sortRunsByCreated(runs)[0];
 

diff --git a/frontend/src/utilities/sortByCreatedAt.ts b/frontend/src/utilities/sortByCreatedAt.ts