Change empty global model mesh serving link text to project display name

opendatahub-io · Nov 13, 2023 · 263e7a1 · 263e7a1
1 parent 8344e6d
commit 263e7a1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/frontend/src/__tests__/integration/pages/modelServing/ModelServingGlobal.spec.ts b/frontend/src/__tests__/integration/pages/modelServing/ModelServingGlobal.spec.ts
@@ -10,7 +10,7 @@ test('Empty State No Serving Runtime', async ({ page }) => {
   await page.waitForSelector('text=No deployed models yet');
 
   // Test that the button is enabled
-  await expect(page.getByRole('button', { name: 'Go to the Projects page' })).toBeTruthy();
+  await expect(page.getByRole('button', { name: 'Go to Test Project' })).toBeTruthy();
 });
 
 test('Empty State No Inference Service', async ({ page }) => {

diff --git a/frontend/src/pages/modelServing/screens/global/EmptyModelServing.tsx b/frontend/src/pages/modelServing/screens/global/EmptyModelServing.tsx
@@ -16,6 +16,7 @@ import { getProjectModelServingPlatform } from '~/pages/modelServing/screens/pro
 import { ServingRuntimePlatform } from '~/types';
 import { byName, ProjectsContext } from '~/concepts/projects/ProjectsContext';
 import useServingPlatformStatuses from '~/pages/modelServing/useServingPlatformStatuses';
+import { getProjectDisplayName } from '~/pages/projects/utils';
 import ServeModelButton from './ServeModelButton';
 
 const EmptyModelServing: React.FC = () => {
@@ -47,11 +48,9 @@ const EmptyModelServing: React.FC = () => {
         <EmptyStateSecondaryActions>
           <Button
             variant="link"
-            onClick={() =>
-              navigate(project?.metadata.name ? `/projects/${project.metadata.name}` : '/projects')
-            }
+            onClick={() => navigate(project ? `/projects/${project.metadata.name}` : '/projects')}
           >
-            {project?.metadata.name ? `Go to ${project.metadata.name}` : 'Select a project'}
+            {project ? `Go to ${getProjectDisplayName(project)}` : 'Select a project'}
           </Button>
         </EmptyStateSecondaryActions>
       </EmptyState>