fix(12787): high page size for model versions and artifacts (#3224)

Signed-off-by: gitdallas <[email protected]>
opendatahub-io · Sep 18, 2024 · 3a39387 · 3a39387
1 parent da0aa67
commit 3a39387
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/frontend/src/api/modelRegistry/__tests__/custom.spec.ts b/frontend/src/api/modelRegistry/__tests__/custom.spec.ts
@@ -324,7 +324,7 @@ describe('getModelVersionsByRegisteredModel', () => {
     expect(proxyGETMock).toHaveBeenCalledTimes(1);
     expect(proxyGETMock).toHaveBeenCalledWith(
       'hostPath',
-      `/api/model_registry/${MODEL_REGISTRY_API_VERSION}/registered_models/1/versions`,
+      `/api/model_registry/${MODEL_REGISTRY_API_VERSION}/registered_models/1/versions?pageSize=99999`,
       {},
       K8sAPIOptionsMock,
     );
@@ -339,7 +339,7 @@ describe('getModelArtifactsByModelVersion', () => {
     expect(proxyGETMock).toHaveBeenCalledTimes(1);
     expect(proxyGETMock).toHaveBeenCalledWith(
       'hostPath',
-      `/api/model_registry/${MODEL_REGISTRY_API_VERSION}/model_versions/1/artifacts`,
+      `/api/model_registry/${MODEL_REGISTRY_API_VERSION}/model_versions/1/artifacts?pageSize=99999`,
       {},
       K8sAPIOptionsMock,
     );

diff --git a/frontend/src/api/modelRegistry/custom.ts b/frontend/src/api/modelRegistry/custom.ts
@@ -161,25 +161,27 @@ export const getListRegisteredModels =
       ),
     );
 
+// TODO: the pageSize value here is temporary until we implement filter/sort on serverside, https://issues.redhat.com/browse/RHOAIENG-12800
 export const getModelVersionsByRegisteredModel =
   (hostpath: string) =>
   (opts: K8sAPIOptions, registeredmodelId: string): Promise<ModelVersionList> =>
     handleModelRegistryFailures(
       proxyGET(
         hostpath,
-        `/api/model_registry/${MODEL_REGISTRY_API_VERSION}/registered_models/${registeredmodelId}/versions`,
+        `/api/model_registry/${MODEL_REGISTRY_API_VERSION}/registered_models/${registeredmodelId}/versions?pageSize=99999`,
         {},
         opts,
       ),
     );
 
+// TODO: the pageSize value here is temporary until we implement filter/sort on serverside, https://issues.redhat.com/browse/RHOAIENG-12800
 export const getModelArtifactsByModelVersion =
   (hostpath: string) =>
   (opts: K8sAPIOptions, modelVersionId: string): Promise<ModelArtifactList> =>
     handleModelRegistryFailures(
       proxyGET(
         hostpath,
-        `/api/model_registry/${MODEL_REGISTRY_API_VERSION}/model_versions/${modelVersionId}/artifacts`,
+        `/api/model_registry/${MODEL_REGISTRY_API_VERSION}/model_versions/${modelVersionId}/artifacts?pageSize=99999`,
         {},
         opts,
       ),