Skip to content

Commit

Permalink
Type added for BufferLike data
Browse files Browse the repository at this point in the history
  • Loading branch information
dpanshug committed Oct 11, 2024
1 parent d0f3eff commit 3d465b5
Showing 1 changed file with 20 additions and 2 deletions.
22 changes: 20 additions & 2 deletions backend/src/routes/wss/k8s/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,24 @@ const waitConnection = (socket: WebSocket, write: () => void) => {
}
};

type BufferLike =
| string
| Buffer
| DataView
| number
| ArrayBufferView
| Uint8Array
| ArrayBuffer
| SharedArrayBuffer
| readonly any[]
| readonly number[]
| { valueOf(): ArrayBuffer }
| { valueOf(): SharedArrayBuffer }
| { valueOf(): Uint8Array }
| { valueOf(): readonly number[] }
| { valueOf(): string }
| { [Symbol.toPrimitive](hint: string): string };

export default async (fastify: KubeFastifyInstance): Promise<void> => {
fastify.get(
'/*',
Expand Down Expand Up @@ -85,7 +103,7 @@ export default async (fastify: KubeFastifyInstance): Promise<void> => {
);

// attach source socket listeners and forward requests to the target
source.on('message', (data: unknown, binary: boolean) =>
source.on('message', (data: BufferLike, binary: boolean) =>
waitConnection(target, () => target.send(data, { binary })),
);
source.on('ping', (data) => waitConnection(target, () => target.ping(data)));
Expand All @@ -95,7 +113,7 @@ export default async (fastify: KubeFastifyInstance): Promise<void> => {
target.on('unexpected-response', onUnexpectedResponse);

// attach target socket listeners and forward requests to the source
target.on('message', (data: unknown, binary: boolean) => source.send(data, { binary }));
target.on('message', (data: BufferLike, binary: boolean) => source.send(data, { binary }));
target.on('ping', (data) => source.ping(data));
target.on('pong', (data) => source.pong(data));
target.on('close', close);
Expand Down

0 comments on commit 3d465b5

Please sign in to comment.