remove unused padding values, use ArtifactTaskNodeProps

opendatahub-io · Apr 5, 2024 · 41cd7f4 · 41cd7f4
1 parent 8fe6561
commit 41cd7f4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/frontend/src/concepts/topology/customNodes/ArtifactTaskNode.tsx b/frontend/src/concepts/topology/customNodes/ArtifactTaskNode.tsx
@@ -14,6 +14,7 @@ import {
   useHover,
   TaskNodeSourceAnchor,
   TaskNodeTargetAnchor,
+  GraphElement,
 } from '@patternfly/react-topology';
 import { ListIcon, MonitoringIcon } from '@patternfly/react-icons';
 import { TaskNodeProps } from '@patternfly/react-topology/dist/esm/pipelines/components/nodes/TaskNode';
@@ -151,7 +152,11 @@ const ArtifactTaskNodeInner: React.FC<ArtifactTaskNodeInnerProps> = observer(
   },
 );
 
-const ArtifactTaskNode: React.FC<TaskNodeProps> = ({ element, ...rest }) => (
+type ArtifactTaskNodeProps = {
+  element: GraphElement;
+} & WithSelectionProps;
+
+const ArtifactTaskNode: React.FC<ArtifactTaskNodeProps> = ({ element, ...rest }) => (
   <ArtifactTaskNodeInner element={element as Node} {...rest} />
 );
 

diff --git a/frontend/src/concepts/topology/utils.ts b/frontend/src/concepts/topology/utils.ts
@@ -7,9 +7,6 @@ export const createNodeId = (prefix = 'node'): string => `${prefix}-${genRandomC
 
 export const ICON_TASK_NODE_TYPE = 'ICON_TASK_NODE';
 
-export const NODE_PADDING_VERTICAL = 0;
-export const NODE_PADDING_HORIZONTAL = 15;
-
 export const ARTIFACT_NODE_WIDTH = 44;
 export const ARTIFACT_NODE_HEIGHT = NODE_HEIGHT;