[RHOAIENG-12310] Error cases for storage class admin table (#3213)

opendatahub-io · Sep 18, 2024 · 4b1e286 · 4b1e286
1 parent 7713555
commit 4b1e286
Show file tree

Hide file tree

Showing 10 changed files with 673 additions and 93 deletions.
diff --git a/frontend/src/__mocks__/mockStorageClasses.ts b/frontend/src/__mocks__/mockStorageClasses.ts
@@ -19,19 +19,28 @@ export const mockStorageClassList = (
   items: storageClasses,
 });
 
-export const buildMockStorageClass = (
+export const buildMockStorageClassConfig = (
   mockStorageClass: MockStorageClass,
   config: Partial<StorageClassConfig>,
+): string =>
+  JSON.stringify({
+    ...JSON.parse(
+      String(mockStorageClass.metadata.annotations?.['opendatahub.io/sc-config'] ?? null),
+    ),
+    ...config,
+  });
+
+export const buildMockStorageClass = (
+  mockStorageClass: MockStorageClass,
+  config: Partial<StorageClassConfig> | string,
 ): MockStorageClass => ({
   ...mockStorageClass,
   metadata: {
     ...mockStorageClass.metadata,
     annotations: {
       ...mockStorageClass.metadata.annotations,
-      'opendatahub.io/sc-config': JSON.stringify({
-        ...JSON.parse(String(mockStorageClass.metadata.annotations?.['opendatahub.io/sc-config'])),
-        ...config,
-      }),
+      'opendatahub.io/sc-config':
+        typeof config !== 'string' ? buildMockStorageClassConfig(mockStorageClass, config) : config,
     },
   },
 });

diff --git a/frontend/src/__tests__/cypress/cypress/pages/storageClasses.ts b/frontend/src/__tests__/cypress/cypress/pages/storageClasses.ts
@@ -29,16 +29,32 @@ class StorageClassesTableRow extends TableRow {
     return this.find().findByTestId('openshift-sc-default-label');
   }
 
-  findEnableSwitch() {
+  findEnableSwitchInput() {
     return this.find().findByTestId('enable-switch');
   }
 
-  findDefaultRadio() {
+  findDefaultRadioInput() {
     return this.find().findByTestId('set-default-radio');
   }
 
-  findOpenshiftScName() {
-    return this.find().find(`[data-label="Openshift storage class"]`);
+  findDisplayNameValue() {
+    return this.find().find(`[data-label="Display name"]`);
+  }
+
+  findEnableValue() {
+    return this.find().find(`[data-label="Enable"]`);
+  }
+
+  findDefaultValue() {
+    return this.find().find(`[data-label="Default"]`);
+  }
+
+  findLastModifiedValue() {
+    return this.find().find(`[data-label="Last modified"]`);
+  }
+
+  findCorruptedMetadataAlert() {
+    return cy.findByTestId('corrupted-metadata-alert');
   }
 }
 
@@ -48,13 +64,19 @@ class StorageClassesTable {
   }
 
   getRowByName(name: string) {
+    return new StorageClassesTableRow(() =>
+      this.find().find(`[data-label="Openshift storage class"]`).contains(name).parents('tr'),
+    );
+  }
+
+  getRowByConfigName(name: string) {
     return new StorageClassesTableRow(() =>
       this.find().find(`[data-label="Display name"]`).contains(name).parents('tr'),
     );
   }
 
   findRowByName(name: string) {
-    return this.getRowByName(name).find();
+    return this.getRowByConfigName(name).find();
   }
 
   mockUpdateStorageClass(storageClassName: string, times?: number) {
@@ -119,6 +141,10 @@ class StorageClassEditModal extends Modal {
     return this.findFooter().findByTestId('modal-submit-button');
   }
 
+  findInfoAlert() {
+    return this.find().findByTestId('edit-sc-modal-info-alert');
+  }
+
   mockUpdateStorageClass(storageClassName: string, times?: number) {
     return cy.interceptOdh(
       `PUT /api/storage-class/:name/config`,