Skip to content

Commit

Permalink
handling suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
uidoyen committed Jul 10, 2023
1 parent 635858a commit 5581898
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 2 additions & 0 deletions frontend/src/concepts/pipelines/const.ts
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
export const PIPELINE_ROUTE_NAME = 'ds-pipeline-pipelines-definition';
export const PIPELINE_DEFINITION_NAME = 'pipelines-definition';
export const TABLE_CONTENT_LIMIT = 5;
export const LIMIT_MAX_ITEM_COUNT = TABLE_CONTENT_LIMIT + 1;
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { PipelineKF, PipelineRunKF } from '~/concepts/pipelines/kfTypes';
import IndentSection from '~/pages/projects/components/IndentSection';
import { FetchState } from '~/utilities/useFetchState';
import { usePipelinesAPI } from '~/concepts/pipelines/context';
import { TABLE_CONTENT_LIMIT } from '~/const';
import { TABLE_CONTENT_LIMIT } from '~/concepts/pipelines/const';
import { RenderContentList, combineRunsByColumn } from './expandedRowRenderUtils';

type PipelinesTableExpandedRowProps = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import {
RunNameForPipeline,
RunStatus,
} from '~/concepts/pipelines/content/tables/renderUtils';
import { LIMIT_MAX_ITEM_COUNT } from '~/const';
import { LIMIT_MAX_ITEM_COUNT } from '~/concepts/pipelines/const';

type PipelinesTableRowProps = {
pipeline: PipelineKF;
Expand Down
2 changes: 0 additions & 2 deletions frontend/src/const.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,3 @@ export const LABEL_SELECTOR_DASHBOARD_RESOURCE = `${KnownLabels.DASHBOARD_RESOUR
export const LABEL_SELECTOR_MODEL_SERVING_PROJECT = `${KnownLabels.MODEL_SERVING_PROJECT}=true`;
export const LABEL_SELECTOR_DATA_CONNECTION_AWS = `${KnownLabels.DATA_CONNECTION_AWS}=true`;
export const LABEL_SELECTOR_PROJECT_SHARING = `${KnownLabels.PROJECT_SHARING}=true`;
export const TABLE_CONTENT_LIMIT = 5;
export const LIMIT_MAX_ITEM_COUNT = 6;
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import usePipelines from '~/concepts/pipelines/apiHooks/usePipelines';
import IndentSection from '~/pages/projects/components/IndentSection';
import { usePipelinesAPI } from '~/concepts/pipelines/context';
import EmptyStateErrorMessage from '~/components/EmptyStateErrorMessage';
import { TABLE_CONTENT_LIMIT, LIMIT_MAX_ITEM_COUNT } from '~/const';
import { TABLE_CONTENT_LIMIT, LIMIT_MAX_ITEM_COUNT } from '~/concepts/pipelines/const';

const PipelinesList: React.FC = () => {
const { namespace } = usePipelinesAPI();
Expand Down

0 comments on commit 5581898

Please sign in to comment.