Merge pull request #1492 from lucferbux/odh-1458

Revamp Model framework label text
opendatahub-io · Jul 11, 2023 · 58d77f1 · 58d77f1
2 parents fe57ee5 + db5cff9
commit 58d77f1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/frontend/src/__tests__/integration/pages/modelServing/ModelServingGlobal.spec.ts b/frontend/src/__tests__/integration/pages/modelServing/ModelServingGlobal.spec.ts
@@ -62,11 +62,8 @@ test('Create model', async ({ page }) => {
   await page.getByLabel('Model Name *').fill('Test Name');
   await page.locator('#inference-service-model-selection').click();
   await page.getByRole('option', { name: 'ovms' }).click();
-  await page
-    .getByText(
-      'Project Test ProjectModel Name * Model servers * OVMS Model ServingModel framework * Sel',
-    )
-    .click();
+  await expect(page.getByText('Model framework (name - version)')).toBeTruthy();
+  await page.locator('#inference-service-framework-selection').click();
   await page.getByRole('option', { name: 'onnx - 1' }).click();
   await expect(await page.getByRole('button', { name: 'Deploy' })).toBeDisabled();
   await page

diff --git a/.../modelServing/screens/projects/InferenceServiceModal/InferenceServiceFrameworkSection.tsx b/.../modelServing/screens/projects/InferenceServiceModal/InferenceServiceFrameworkSection.tsx
@@ -37,7 +37,7 @@ const InferenceServiceFrameworkSection: React.FC<InferenceServiceFrameworkSectio
   }
 
   return (
-    <FormGroup label="Model framework" isRequired>
+    <FormGroup label="Model framework (name - version)" isRequired>
       <Select
         removeFindDomNode
         toggleId="inference-service-framework-selection"