Merge pull request #2438 from alexcreasy/remove-metricsnamespace

Remove last remaining traces of modelMetricsNamespace flag
opendatahub-io · May 15, 2024 · 62f93c0 · 62f93c0
2 parents 95611b7 + 0cd4f81
commit 62f93c0
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 7 deletions.
diff --git a/docs/dashboard-config.md b/docs/dashboard-config.md
@@ -29,7 +29,6 @@ The following are a list of features that are supported, along with there defaul
 | disableKServeAuth            | false   | Disables the ability to use auth in KServe.                                                          |
 | disableModelMesh             | false   | Disables the ability to select ModelMesh as a Serving Platform.                                      |
 | disableAcceleratorProfiles   | false   | Disables Accelerator profiles from the Admin Panel.                                                  |
-| modelMetricsNamespace        | false   | Enables the namespace in which the Model Serving Metrics' Prometheus Operator is installed.          |
 | disableBiasMetrics           | false   | Disables Model Bias tab from Model Serving metrics.                                                  |
 | disablePerformanceMetrics    | false   | Disables Endpoint Performance tab from Model Serving metrics.                                        |
 | disableDistributedWorkloads  | false   | Disables Distributed Workload Metrics from the dashboard.                                            |
@@ -58,7 +57,6 @@ spec:
     disableProjectSharing: false
     disableCustomServingRuntimes: false
     disableAcceleratorProfiles: false
-    modelMetricsNamespace: ''
     disableBiasMetrics: false
     disablePerformanceMetrics: false
     disablePipelineExperiments: false
@@ -153,7 +151,6 @@ spec:
     disableProjectSharing: true
     disableCustomServingRuntimes: false
     disableAcceleratorProfiles: true
-    modelMetricsNamespace: ''
     disableBiasMetrics: false
     disablePerformanceMetrics: false
     disablePipelineExperiments: true

diff --git a/frontend/src/__tests__/cypress/cypress/e2e/projects/__intercept__/project-list.snap.json b/frontend/src/__tests__/cypress/cypress/e2e/projects/__intercept__/project-list.snap.json
@@ -53,7 +53,6 @@
                   "f:disablePerformanceMetrics": {},
                   "f:disableTracking": {},
                   "f:enablement": {},
-                  "f:modelMetricsNamespace": {}
                 },
                 "f:groupsConfig": { ".": {}, "f:adminGroups": {}, "f:allowedGroups": {} },
                 "f:notebookController": {
@@ -115,7 +114,6 @@
           "disableModelServing": false,
           "disableProjectSharing": false,
           "disableCustomServingRuntimes": false,
-          "modelMetricsNamespace": "",
           "disablePipelines": false,
           "disableKServe": false,
           "disableModelMesh": false

diff --git a/frontend/src/concepts/areas/types.ts b/frontend/src/concepts/areas/types.ts
@@ -6,8 +6,7 @@ import {
   DataScienceClusterKindStatus,
 } from '~/k8sTypes';
 
-// TODO: clean up this definition / update the DashboardConfig to a better state
-export type FeatureFlag = keyof Omit<DashboardCommonConfig, 'modelMetricsNamespace'>;
+export type FeatureFlag = keyof DashboardCommonConfig;
 
 export type IsAreaAvailableStatus = {
   /** A single boolean status */