Events are in correct order in workbench status progress

opendatahub-io · Sep 26, 2024 · 65d13c8 · 65d13c8
1 parent d5938bf
commit 65d13c8
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/frontend/src/pages/notebookController/screens/server/StartServerModal.tsx b/frontend/src/pages/notebookController/screens/server/StartServerModal.tsx
@@ -220,7 +220,10 @@ const StartServerModal: React.FC<StartServerModalProps> = ({ open, spawnInProgre
       <List isPlain isBordered tabIndex={0}>
         {events
           .slice()
-          .reverse()
+          .toSorted(
+            (a, b) =>
+              new Date(getEventTimestamp(b)).getTime() - new Date(getEventTimestamp(a)).getTime(),
+          )
           .map((event, index) => (
             <ListItem key={`notebook-event-${event.metadata.uid ?? index}`}>
               {`${getEventTimestamp(event)} [${event.type}] ${event.message}`}

diff --git a/frontend/src/pages/projects/notebook/StartNotebookModal.tsx b/frontend/src/pages/projects/notebook/StartNotebookModal.tsx
@@ -19,7 +19,7 @@ import { EventStatus, NotebookStatus } from '~/types';
 import { EventKind } from '~/k8sTypes';
 import NotebookRouteLink from './NotebookRouteLink';
 import { NotebookState } from './types';
-import { getEventFullMessage } from './utils';
+import { getEventFullMessage, getEventTimestamp } from './utils';
 
 type StartNotebookModalProps = {
   isOpen: boolean;
@@ -164,7 +164,11 @@ const StartNotebookModal: React.FC<StartNotebookModalProps> = ({
             <List isPlain isBordered data-id="event-logs">
               {events
                 .slice()
-                .reverse()
+                .toSorted(
+                  (a, b) =>
+                    new Date(getEventTimestamp(b)).getTime() -
+                    new Date(getEventTimestamp(a)).getTime(),
+                )
                 .map((event, index) => (
                   <ListItem key={`notebook-event-${event.metadata.uid ?? index}`}>
                     {getEventFullMessage(event)}