Fixes bug with stack charts where chart domain is truncated (#2090)

opendatahub-io · Nov 10, 2023 · 6858ebd · 6858ebd
1 parent 99cda34
commit 6858ebd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/frontend/src/pages/modelServing/screens/metrics/MetricsChart.tsx b/frontend/src/pages/modelServing/screens/metrics/MetricsChart.tsx
@@ -40,7 +40,6 @@ import {
 import {
   convertTimestamp,
   createGraphMetricLine,
-  defaultDomainCalculator,
   formatToShow,
   getThresholdData,
   useStableMetrics,
@@ -63,7 +62,7 @@ const MetricsChart: React.FC<MetricsChartProps> = ({
   color,
   metrics: unstableMetrics,
   thresholds = [],
-  domain = defaultDomainCalculator,
+  domain,
   toolbar,
   type = MetricsChartTypes.AREA,
   isStack = false,
@@ -189,7 +188,7 @@ const MetricsChart: React.FC<MetricsChartProps> = ({
             <Chart
               ariaTitle={title}
               containerComponent={containerComponent}
-              domain={domain(maxYValue, minYValue)}
+              domain={domain ? domain(maxYValue, minYValue) : undefined}
               height={400}
               width={chartWidth}
               padding={{ left: 70, right: 50, bottom: 70, top: 50 }}

diff --git a/frontend/src/pages/modelServing/screens/metrics/utils.tsx b/frontend/src/pages/modelServing/screens/metrics/utils.tsx
@@ -14,7 +14,6 @@ import {
 import { QueryTimeframeStep } from '~/pages/modelServing/screens/const';
 import {
   BiasSelectOption,
-  DomainCalculator,
   GraphMetricLine,
   GraphMetricPoint,
   MetricChartLine,
@@ -170,10 +169,6 @@ export const useStableMetrics = (
   return metricsRef.current;
 };
 
-export const defaultDomainCalculator: DomainCalculator = (maxYValue) => ({
-  y: maxYValue === 0 ? [0, 1] : [0, maxYValue],
-});
-
 export const getBreadcrumbItemComponents = (breadcrumbItems: BreadcrumbItemType[]) =>
   breadcrumbItems.map((item) => (
     <BreadcrumbItem