Skip to content

Commit

Permalink
Merge pull request #2810 from gitdallas/feat/mr-admin-scaffolding
Browse files Browse the repository at this point in the history
feat(mr): mr settings scaffolding
  • Loading branch information
openshift-merge-bot[bot] authored May 16, 2024
2 parents f945d43 + 39b7693 commit 6d6542b
Show file tree
Hide file tree
Showing 4 changed files with 65 additions and 0 deletions.
4 changes: 4 additions & 0 deletions frontend/src/app/AppRoutes.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ const ClusterSettingsPage = React.lazy(() => import('../pages/clusterSettings/Cl
const CustomServingRuntimeRoutes = React.lazy(
() => import('../pages/modelServing/customServingRuntimes/CustomServingRuntimeRoutes'),
);
const ModelRegistrySettingsPage = React.lazy(
() => import('../pages/modelRegistrySettings/ModelRegistrySettings'),
);
const GroupSettingsPage = React.lazy(() => import('../pages/groupSettings/GroupSettings'));
const LearningCenterPage = React.lazy(() => import('../pages/learningCenter/LearningCenter'));
const BYONImagesPage = React.lazy(() => import('../pages/BYONImages/BYONImages'));
Expand Down Expand Up @@ -127,6 +130,7 @@ const AppRoutes: React.FC = () => {
<Route path="/clusterSettings" element={<ClusterSettingsPage />} />
<Route path="/acceleratorProfiles/*" element={<AcceleratorProfileRoutes />} />
<Route path="/servingRuntimes/*" element={<CustomServingRuntimeRoutes />} />
<Route path="/modelRegistrySettings" element={<ModelRegistrySettingsPage />} />
<Route path="/groupSettings" element={<GroupSettingsPage />} />
</>
)}
Expand Down
1 change: 1 addition & 0 deletions frontend/src/concepts/areas/const.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,5 +80,6 @@ export const SupportedAreasStateMap: SupportedAreasState = {
[SupportedArea.MODEL_REGISTRY]: {
featureFlags: ['disableModelRegistry'],
requiredComponents: [StackComponent.MODEL_REGISTRY],
requiredCapabilities: [StackCapability.SERVICE_MESH, StackCapability.SERVICE_MESH_AUTHZ],
},
};
50 changes: 50 additions & 0 deletions frontend/src/pages/modelRegistrySettings/ModelRegistrySettings.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
import React from 'react';
import { useNavigate } from 'react-router-dom';
import {
Button,
EmptyState,
EmptyStateActions,
EmptyStateBody,
EmptyStateFooter,
EmptyStateHeader,
EmptyStateIcon,
EmptyStateVariant,
} from '@patternfly/react-core';
import { PlusCircleIcon } from '@patternfly/react-icons';
import ApplicationsPage from '~/pages/ApplicationsPage';

const ModelRegistrySettings: React.FC = () => {
const navigate = useNavigate();

return (
<ApplicationsPage
title="Model Registry Settings"
description="Manage model registry settings for all users in your organization."
loaded
empty={false}
errorMessage="Unable to load model registry settings."
emptyMessage="No model registry settings found."
provideChildrenPadding
>
<EmptyState variant={EmptyStateVariant.lg}>
<EmptyStateHeader
titleText="No model registries"
icon={<EmptyStateIcon icon={PlusCircleIcon} />}
headingLevel="h5"
/>
<EmptyStateBody>
You can create model registries for specific users or projects.
</EmptyStateBody>
<EmptyStateFooter>
<EmptyStateActions>
<Button variant="primary" onClick={() => navigate('/modelRegistry')}>
Create model registry
</Button>
</EmptyStateActions>
</EmptyStateFooter>
</EmptyState>
</ApplicationsPage>
);
};

export default ModelRegistrySettings;
10 changes: 10 additions & 0 deletions frontend/src/utilities/NavData.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,15 @@ const useCustomRuntimesNav = (): NavDataHref[] =>
},
]);

const useModelRegisterySettingsNav = (): NavDataHref[] =>
useAreaCheck<NavDataHref>(SupportedArea.MODEL_REGISTRY, [
{
id: 'settings-model-registry',
label: 'Model registry settings',
href: '/modelRegistrySettings',
},
]);

const useUserManagementNav = (): NavDataHref[] =>
useAreaCheck<NavDataHref>(SupportedArea.USER_MANAGEMENT, [
{
Expand All @@ -174,6 +183,7 @@ const useSettingsNav = (): NavDataGroup[] => {
...useClusterSettingsNav(),
...useAcceleratorProfilesNav(),
...useCustomRuntimesNav(),
...useModelRegisterySettingsNav(),
...useUserManagementNav(),
];

Expand Down

0 comments on commit 6d6542b

Please sign in to comment.