Skip to content

Commit

Permalink
addressed comments
Browse files Browse the repository at this point in the history
  • Loading branch information
YuliaKrimerman committed Oct 15, 2024
1 parent 8d7a723 commit 702231d
Showing 1 changed file with 5 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ enum ConditionStatus {
True = 'True',
False = 'False',
}

interface ModelRegistryTableRowStatusProps {
conditions: K8sCondition[] | undefined;
}
Expand Down Expand Up @@ -118,9 +117,13 @@ export const ModelRegistryTableRowStatus: React.FC<ModelRegistryTableRowStatusPr
}
}

const isClickable =
statusLabel === ModelRegistryStatusLabel.Unavailable ||
statusLabel === ModelRegistryStatusLabel.Degrading;

const label = (
<Label
onClick={() => void 0}
{...(isClickable ? { onClick: () => {} } : {})}
data-testid="model-registry-label"
icon={icon}
color={color}

Check failure on line 129 in frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx

View workflow job for this annotation

GitHub Actions / Tests (18.x)

Unexpected empty method 'onClick'
Expand Down

0 comments on commit 702231d

Please sign in to comment.