Skip to content

Commit

Permalink
Fix remaining build errors
Browse files Browse the repository at this point in the history
  • Loading branch information
jeff-phillips-18 committed Aug 21, 2024
1 parent 2894ce9 commit 7330248
Show file tree
Hide file tree
Showing 20 changed files with 34 additions and 34 deletions.
2 changes: 1 addition & 1 deletion frontend/src/components/DashboardDescriptionListGroup.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ const DashboardDescriptionListGroup: React.FC<DashboardDescriptionListGroupProps
</Flex>
</DescriptionListTerm>
)}
<DescriptionListDescription className={isEmpty && !isEditing ? text.disabledColor_100 : ''}>
<DescriptionListDescription className={isEmpty && !isEditing ? text.textColorDisabled : ''}>
{isEditing ? contentWhenEditing : isEmpty ? contentWhenEmpty : children}
</DescriptionListDescription>
</DescriptionListGroup>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/FilterToolbar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ function FilterToolbar<T extends string>({
<ToolbarFilter
categoryName="Filters"
data-testid={`${testId}-text-field`}
variant="search-filter"
variant="label"
labels={keys
.map<ToolbarLabel | null>((filterKey) => {
const optionValue = filterOptions[filterKey];
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/SimpleSelect.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ import * as React from 'react';
import {
Truncate,
MenuToggle,
MenuToggleProps,
Select,
SelectList,
SelectOption,
SelectGroup,
Divider,
} from '@patternfly/react-core';
import { MenuToggleProps } from '@patternfly/react-core/src/components/MenuToggle/MenuToggle';

import './SimpleSelect.scss';

Expand Down
8 changes: 4 additions & 4 deletions frontend/src/concepts/distributedWorkloads/utils.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ import {
} from '@patternfly/react-icons';
import { SVGIconProps } from '@patternfly/react-icons/dist/esm/createIcon';
import {
chart_color_cyan_300 as chartColorCyan,
chart_color_gold_300 as chartColorGold,
chart_color_teal_300 as chartColorCyan,
chart_color_red_orange_300 as chartColorGold,
chart_color_purple_300 as chartColorPurple,
chart_color_blue_300 as chartColorBlue,
chart_color_black_300 as chartColorBlack,
Expand Down Expand Up @@ -65,12 +65,12 @@ export const WorkloadStatusColorAndIcon: Record<
Pick<WorkloadStatusInfo, 'color' | 'chartColor' | 'icon'>
> = {
Pending: {
color: 'cyan',
color: 'teal',
chartColor: chartColorCyan.value,
icon: PendingIcon,
},
Inadmissible: {
color: 'gold',
color: 'orangered',
chartColor: chartColorGold.value,
icon: ExclamationTriangleIcon,
},
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Stack, StackItem } from '@patternfly/react-core/dist/esm';
import { Stack, StackItem } from '@patternfly/react-core';
import React from 'react';
import { KserveMetricGraphDefinition } from '~/concepts/metrics/kserve/types';
import { KserveMetricsGraphTypes } from '~/concepts/metrics/kserve/const';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export const DuplicateNameHelperText: React.FC<DuplicateNameHelperTextProps> = (
isError,
}) => {
const helperTextItemProps: HelperTextItemProps = isError
? { variant: 'error', hasIcon: true }
? { variant: 'error' }
: {
icon: (
<Icon status="info">
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
import { EmptyState, EmptyStateVariant, EmptyStateBody } from '@patternfly/react-core';
import React from 'react';

type CompareRunsEmptyStateProps = Omit<React.ComponentProps<typeof EmptyState>, 'children'> & {
type CompareRunsEmptyStateProps = Omit<
React.ComponentProps<typeof EmptyState>,
'children' | 'titleText'
> & {
title?: string;
};

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
import { EmptyState, EmptyStateVariant, EmptyStateBody } from '@patternfly/react-core';
import React from 'react';

type CompareRunsNoMetricsProps = Omit<React.ComponentProps<typeof EmptyState>, 'children'> & {
type CompareRunsNoMetricsProps = Omit<
React.ComponentProps<typeof EmptyState>,
'children' | 'titleText'
> & {
title?: string;
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export const CustomMetricsColumnsModal: React.FC<CustomMetricsColumnsModalProps>
const metricsColumnsLocalStorageKey = getMetricsColumnsLocalStorageKey(experimentId ?? '');
const selectedColumnNames = Object.values(columns).reduce((acc: string[], column) => {
if (column.props.checked) {
acc.push(column.id);
acc.push(String(column.id));
}
return acc;
}, []);
Expand Down Expand Up @@ -64,7 +64,7 @@ export const CustomMetricsColumnsModal: React.FC<CustomMetricsColumnsModalProps>

if (searchText) {
newColumns = defaultColumns.filter((column) =>
column.id.toLowerCase().includes(searchText.toLowerCase()),
String(column.id).toLowerCase().includes(searchText.toLowerCase()),
);
}

Expand Down Expand Up @@ -108,7 +108,7 @@ export const CustomMetricsColumnsModal: React.FC<CustomMetricsColumnsModalProps>

const columnCheckbox = (
<Checkbox
id={id}
id={String(id)}
isChecked={checked}
isDisabled={isDisabled}
onChange={(_, isChecked) =>
Expand Down Expand Up @@ -150,7 +150,7 @@ export const CustomMetricsColumnsModal: React.FC<CustomMetricsColumnsModalProps>
props: { checked },
};
})}
variant="defaultWithHandle"
variant="default"
onDrop={(_, newColumns) => {
setFilteredColumns(newColumns);
setColumns(newColumns);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const ModelPropertiesDescriptionListGroup: React.FC<ModelPropertiesDescriptionLi
const allExistingKeys = Object.keys(customProperties);

const requiredAsterisk = (
<span aria-hidden="true" className={text.dangerColor_100}>
<span aria-hidden="true" className={text.textColorStatusDanger}>
{' *'}
</span>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ const ModelVersionDetailsView: React.FC<ModelVersionDetailsViewProps> = ({
clickTip="Copied"
variant="inline-compact"
>
{modelArtifact.items[0]?.uri}
{modelArtifact.items[0]?.uri || ''}
</ClipboardCopy>
</DashboardDescriptionListGroup>
<DashboardDescriptionListGroup
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ const ModelVersionListView: React.FC<ModelVersionListViewProps> = ({
icon={<FilterIcon />}
/>
</ToolbarFilter>
<ToolbarItem variant="search-filter">
<ToolbarItem variant="label">
<SearchInput
placeholder={`Find by ${searchType.toLowerCase()}`}
value={search}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ const ModelVersionsArchiveListView: React.FC<ModelVersionsArchiveListViewProps>
icon={<FilterIcon />}
/>
</ToolbarFilter>
<ToolbarItem variant="search-filter">
<ToolbarItem variant="label">
<SearchInput
placeholder={`Find by ${searchType.toLowerCase()}`}
value={search}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ const RegisteredModelListView: React.FC<RegisteredModelListViewProps> = ({
icon={<FilterIcon />}
/>
</ToolbarFilter>
<ToolbarItem variant="search-filter">
<ToolbarItem variant="label">
<SearchInput
placeholder={`Find by ${searchType.toLowerCase()}`}
value={search}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ const RegisteredModelsArchiveListView: React.FC<RegisteredModelsArchiveListViewP
icon={<FilterIcon />}
/>
</ToolbarFilter>
<ToolbarItem variant="search-filter">
<ToolbarItem variant="label">
<SearchInput
placeholder={`Find by ${searchType.toLowerCase()}`}
value={search}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import {
EmptyStateActions,
EmptyStateBody,
EmptyStateFooter,
EmptyStateIconProps,
EmptyStateVariant,
} from '@patternfly/react-core';
import { PlusCircleIcon } from '@patternfly/react-icons';
Expand All @@ -19,7 +18,7 @@ type EmptyModelRegistryStateType = {
primaryActionOnClick?: () => void;
secondaryActionText?: string;
secondaryActionOnClick?: () => void;
headerIcon?: EmptyStateIconProps['icon'];
headerIcon?: React.ComponentType;
customAction?: React.ReactNode;
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export const ModelRegistryTableRowStatus: React.FC<ModelRegistryTableRowStatusPr
) {
statusLabel = ModelRegistryStatusLabel.Degrading;
icon = <DegradedIcon />;
color = 'gold';
color = 'orangered';
popoverTitle = 'Service is degrading';
}
// Unavailable
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const InternalServicePopoverContent: React.FC<InternalServicePopoverContentProps
clickTip="Copied"
variant={ClipboardCopyVariant.inlineCompact}
>
{inferenceService.status?.address?.url}
{inferenceService.status?.address?.url ?? ''}
</ClipboardCopy>
</DescriptionListDescription>
</DescriptionListGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import {
FlexItem,
Content,
GalleryItem,
TextListItemVariants,
TextListVariants,
} from '@patternfly/react-core';
import { Link } from 'react-router-dom';
import { ProjectObjectType } from '~/concepts/design/utils';
Expand Down Expand Up @@ -68,15 +66,12 @@ const DeployedModelCard: React.FC<DeployedModelCardProps> = ({
</CardHeader>
<CardBody>
<Content>
<Content component={TextListVariants.dl} style={{ display: 'block' }}>
<Content
component={TextListItemVariants.dt}
style={{ marginBottom: 'var(--pf-v6-global--spacer--xs)' }}
>
<Content component="dl" style={{ display: 'block' }}>
<Content component="dt" style={{ marginBottom: 'var(--pf-v6-global--spacer--xs)' }}>
Serving runtime
</Content>
<Content
component={TextListItemVariants.dd}
component="dd"
style={{
fontSize: 'var(--pf-v6-global--FontSize--sm)',
color: !servingRuntime ? 'var(--pf-v6-global--Color--200)' : undefined,
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/utilities/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export const getLabelColorForDocType = (docType: string): LabelProps['color'] =>
case OdhDocumentType.Documentation:
return 'orange';
case OdhDocumentType.Tutorial:
return 'cyan';
return 'teal';
case OdhDocumentType.QuickStart:
return 'green';
case OdhDocumentType.HowTo:
Expand Down

0 comments on commit 7330248

Please sign in to comment.