PR feedback from Gage, add params

opendatahub-io · Apr 30, 2024 · 7dfd49a · 7dfd49a
1 parent 882e8f2
commit 7dfd49a
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/frontend/src/concepts/pipelines/topology/usePipelineTaskTopology.ts b/frontend/src/concepts/pipelines/topology/usePipelineTaskTopology.ts
@@ -29,14 +29,19 @@ const getNestedNodes = (
   components: PipelineComponentsKF,
   executors: PipelineExecutorsKF,
   runDetails?: RunDetailsKF,
+  executions?: Execution[] | null,
 ): [nestedNodes: PipelineNodeModelExpanded[], children: string[]] => {
   const nodes: PipelineNodeModelExpanded[] = [];
   const children: string[] = [];
 
   Object.entries(items).forEach(([name, details]) => {
     const componentRef = details.componentRef.name;
     const component = components[componentRef];
-    const status = parseRuntimeInfoFromRunDetails(name, runDetails);
+
+    const status = executions
+      ? parseRuntimeInfoFromExecutions(name, executions)
+      : parseRuntimeInfoFromRunDetails(name, runDetails);
+
     const runAfter: string[] = details.dependentTasks ?? [];
     const hasSubTask =
       Object.keys(components).find((task) => task === componentRef) &&
@@ -56,7 +61,14 @@ const getNestedNodes = (
     };
 
     if (hasSubTask && subTasks) {
-      const [nestedNodes, nestedChildren] = getNestedNodes(spec, subTasks, components, executors);
+      const [nestedNodes, nestedChildren] = getNestedNodes(
+        spec,
+        subTasks,
+        components,
+        executors,
+        runDetails,
+        executions,
+      );
 
       const itemNode = createGroupNode(
         name,