Make notebook controller access button to link behavior

opendatahub-io · Aug 24, 2023 · 7f4fcf9 · 7f4fcf9
1 parent d61c590
commit 7f4fcf9
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/frontend/src/pages/notebookController/screens/server/NotebookServer.tsx b/frontend/src/pages/notebookController/screens/server/NotebookServer.tsx
@@ -34,6 +34,8 @@ export const NotebookServer: React.FC = () => {
     [requestNotebookRefresh, navigate],
   );
 
+  const link = notebook?.metadata.annotations?.['opendatahub.io/link'] || '#';
+
   return (
     <>
       <ImpersonateAlert />
@@ -54,18 +56,17 @@ export const NotebookServer: React.FC = () => {
               />
               <ActionList>
                 <ActionListItem
-                  onClick={() => {
-                    if (notebook.metadata.annotations?.['opendatahub.io/link']) {
-                      window.location.href = notebook.metadata.annotations['opendatahub.io/link'];
-                    } else {
+                  onClick={(e) => {
+                    if (link === '#') {
+                      e.preventDefault();
                       notification.error(
                         'Error accessing notebook server',
                         'Failed to redirect page due to missing notebook URL, please try to refresh the page and try it again.',
                       );
                     }
                   }}
                 >
-                  <Button data-id="return-nb-button" variant="primary">
+                  <Button component="a" href={link} data-id="return-nb-button">
                     Access notebook server
                   </Button>
                 </ActionListItem>