feat(mr): undo separate disableModelRegistryManager flag

Signed-off-by: gitdallas <[email protected]>
opendatahub-io · May 13, 2024 · ca003db · ca003db
1 parent ac8ebd8
commit ca003db
Show file tree

Hide file tree

Showing 9 changed files with 1 addition and 14 deletions.
diff --git a/backend/src/types.ts b/backend/src/types.ts
@@ -18,7 +18,6 @@ export type DashboardConfig = K8sResourceCommon & {
       disableInfo: boolean;
       disableSupport: boolean;
       disableClusterManager: boolean;
-      disableModelRegistryManager: boolean;
       disableTracking: boolean;
       disableBYONImageStream: boolean;
       disableISVBadges: boolean;

diff --git a/backend/src/utils/constants.ts b/backend/src/utils/constants.ts
@@ -43,7 +43,6 @@ export const blankDashboardCR: DashboardConfig = {
       disableInfo: false,
       disableSupport: false,
       disableClusterManager: false,
-      disableModelRegistryManager: false,
       disableTracking: true,
       disableBYONImageStream: false,
       disableISVBadges: false,

diff --git a/docs/dashboard-config.md b/docs/dashboard-config.md
@@ -14,7 +14,6 @@ The following are a list of features that are supported, along with there defaul
 | disableInfo                  | false   | Removes the information panel in Explore Application section                                         |
 | disableSupport               | false   | Disables components related to support.                                                              |
 | disableClusterManager        | false   | Disables cluster management section for admins                                                       |
-| disableModelRegistryManager  | false   | Disables model registry management section for admins                                                |
 | disableTracking              | true    | Disables telemetry UI data. Note for this feature to work you need woopra and segement.io configured |
 | disableBYONImageStream       | false   | Disables custom notebook images that are created via image streams                                   |
 | disableISVBadges             | false   | Removes the badge that indicate if a product is ISV or not.                                          |
@@ -47,7 +46,6 @@ spec:
     disableInfo: false
     disableSupport: false
     disableClusterManager: false
-    disableModelRegistryManager: false
     disableTracking: true
     disableBYONImageStream: false
     disableISVBadges: false
@@ -144,7 +142,6 @@ spec:
     enablement: true
     disableBYONImageStream: false
     disableClusterManager: false
-    disableModelRegistryManager: false
     disableISVBadges: false
     disableInfo: false
     disableSupport: false

diff --git a/frontend/src/__mocks__/mockDashboardConfig.ts b/frontend/src/__mocks__/mockDashboardConfig.ts
@@ -4,7 +4,6 @@ type MockDashboardConfigType = {
   disableInfo?: boolean;
   disableSupport?: boolean;
   disableClusterManager?: boolean;
-  disableModelRegistryManager?: boolean;
   disableTracking?: boolean;
   disableBYONImageStream?: boolean;
   disableISVBadges?: boolean;
@@ -31,7 +30,6 @@ export const mockDashboardConfig = ({
   disableInfo = false,
   disableSupport = false,
   disableClusterManager = false,
-  disableModelRegistryManager = false,
   disableTracking = false,
   disableBYONImageStream = false,
   disableISVBadges = false,
@@ -68,7 +66,6 @@ export const mockDashboardConfig = ({
       disableInfo,
       disableSupport,
       disableClusterManager,
-      disableModelRegistryManager,
       disableTracking,
       disableBYONImageStream,
       disableISVBadges,

diff --git a/frontend/src/concepts/areas/const.ts b/frontend/src/concepts/areas/const.ts
@@ -11,7 +11,7 @@ export const SupportedAreasStateMap: SupportedAreasState = {
     featureFlags: ['disableClusterManager'],
   },
   [SupportedArea.MODEL_REGISTRY_SETTINGS]: {
-    featureFlags: ['disableModelRegistryManager'],
+    featureFlags: ['disableModelRegistry'],
     requiredComponents: [StackComponent.MODEL_REGISTRY],
     requiredCapabilities: [StackCapability.SERVICE_MESH, StackCapability.SERVICE_MESH_AUTHZ],
   },

diff --git a/frontend/src/k8sTypes.ts b/frontend/src/k8sTypes.ts
@@ -1196,7 +1196,6 @@ export type DashboardCommonConfig = {
   disableInfo: boolean;
   disableSupport: boolean;
   disableClusterManager: boolean;
-  disableModelRegistryManager: boolean;
   disableTracking: boolean;
   disableBYONImageStream: boolean;
   disableISVBadges: boolean;

diff --git a/manifests/crd/odhdashboardconfigs.opendatahub.io.crd.yaml b/manifests/crd/odhdashboardconfigs.opendatahub.io.crd.yaml
@@ -33,8 +33,6 @@ spec:
                       type: boolean
                     disableClusterManager:
                       type: boolean
-                    disableModelRegistryManager:
-                      type: boolean
                     disableTracking:
                       type: boolean
                     disableBYONImageStream:

diff --git a/manifests/overlays/odhdashboardconfig/odh-dashboard-config.yaml b/manifests/overlays/odhdashboardconfig/odh-dashboard-config.yaml
@@ -8,7 +8,6 @@ spec:
   dashboardConfig:
     disableBYONImageStream: false
     disableClusterManager: false
-    disableModelRegistryManager: false
     disableISVBadges: false
     disableInfo: false
     disableSupport: false

diff --git a/manifests/overlays/odhdashboardconfig/odhdashboardconfig.yaml b/manifests/overlays/odhdashboardconfig/odhdashboardconfig.yaml
@@ -8,7 +8,6 @@ spec:
   dashboardConfig:
     disableBYONImageStream: false
     disableClusterManager: false
-    disableModelRegistryManager: false
     disableISVBadges: false
     disableInfo: false
     disableSupport: false