Skip to content

Commit

Permalink
[REVERT ME] temporarily change namespace to secure-model-registries f…
Browse files Browse the repository at this point in the history
…or testing

Signed-off-by: Mike Turley <[email protected]>
  • Loading branch information
mturley committed Sep 12, 2024
1 parent 71550c0 commit e51dd17
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ ifdef NAMESPACE
'oc port-forward -n ${NAMESPACE} svc/ds-pipeline-md-${DSPA_NAME} ${METADATA_ENVOY_SERVICE_PORT}:8443' \
'oc port-forward -n ${NAMESPACE} svc/ds-pipeline-${DSPA_NAME} ${DS_PIPELINE_DSPA_SERVICE_PORT}:8443' \
'oc port-forward -n ${NAMESPACE} svc/${TRUSTYAI_NAME}-tls ${TRUSTYAI_TAIS_SERVICE_PORT}:443' \
'oc port-forward -n odh-model-registries svc/${MODEL_REGISTRY_NAME} ${MODEL_REGISTRY_SERVICE_PORT}:8080'
'oc port-forward -n secure-model-registries svc/${MODEL_REGISTRY_NAME} ${MODEL_REGISTRY_SERVICE_PORT}:8080'
else
$(error Missing NAMESPACE variable)
endif
Expand Down
2 changes: 1 addition & 1 deletion backend/src/routes/api/service/modelregistry/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default proxyService(
},
{
// Use port forwarding for local development:
// kubectl port-forward -n odh-model-registries svc/<service-name> 8085:8080
// kubectl port-forward -n secure-model-registries svc/<service-name> 8085:8080
host: process.env.MODEL_REGISTRY_SERVICE_HOST,
port: process.env.MODEL_REGISTRY_SERVICE_PORT,
},
Expand Down
2 changes: 1 addition & 1 deletion backend/src/utils/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ export const THANOS_INSTANCE_NAME = 'thanos-querier';
export const THANOS_NAMESPACE = 'openshift-monitoring';
export const LABEL_SELECTOR_DASHBOARD_RESOURCE = `${KnownLabels.DASHBOARD_RESOURCE}=true`;

export const MODEL_REGISTRY_NAMESPACE = 'odh-model-registries';
export const MODEL_REGISTRY_NAMESPACE = 'secure-model-registries';

export const SERVICE_ADDRESS_ANNOTATIONS: Record<ServiceAddressType, string | null> = {
[ServiceAddressType.INTERNAL]: null,
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/__mocks__/mockModelRegistryService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ type MockServiceType = {

export const mockModelRegistryService = ({
name = 'modelregistry-sample',
namespace = 'odh-model-registries',
namespace = 'secure-model-registries',
}: MockServiceType): ServiceKind => ({
kind: 'Service',
apiVersion: 'v1',
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/__mocks__/mockSelfSubjectRulesReview.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export const mockSelfSubjectRulesReview = (): SelfSubjectRulesReviewKind => ({
kind: 'SelfSubjectRulesReview',
apiVersion: 'authorization.k8s.io/v1',
spec: {
namespace: 'odh-model-registries',
namespace: 'secure-model-registries',
},
status: {
resourceRules: [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { mockModelRegistry } from '~/__mocks__/mockModelRegistry';
import { mockGroup } from '~/__mocks__/mockGroup';
import { modelRegistryPermissions } from '~/__tests__/cypress/cypress/pages/modelRegistryPermissions';

const MODEL_REGISTRY_DEFAULT_NAMESPACE = 'odh-model-registries';
const MODEL_REGISTRY_DEFAULT_NAMESPACE = 'secure-model-registries';

const userSubjects: RoleBindingSubject[] = [
{
Expand Down Expand Up @@ -452,7 +452,7 @@ describe('MR Permissions', () => {
cy.wait('@addProject').then((interception) => {
expect(interception.request.body).to.containSubset({
metadata: {
namespace: 'odh-model-registries',
namespace: 'secure-model-registries',
},
roleRef: {
apiGroup: 'rbac.authorization.k8s.io',
Expand Down Expand Up @@ -498,7 +498,7 @@ describe('MR Permissions', () => {
cy.wait('@editProject').then((interception) => {
expect(interception.request.body).to.containSubset({
metadata: {
namespace: 'odh-model-registries',
namespace: 'secure-model-registries',
},
roleRef: {
apiGroup: 'rbac.authorization.k8s.io',
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/concepts/modelRegistry/const.ts
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
export const MODEL_REGISTRY_DEFAULT_NAMESPACE = 'odh-model-registries'; // The default namespace for the model registry service, controlled by the operator.
export const MODEL_REGISTRY_DEFAULT_NAMESPACE = 'secure-model-registries'; // The default namespace for the model registry service, controlled by the operator.
export const MODEL_REGISTRY_API_VERSION = 'v1alpha3';

0 comments on commit e51dd17

Please sign in to comment.