fix: RHOAIENG-14037 - added another line of helper text and removed '…

…Mi' option Signed-off-by: Olga Lavtar <[email protected]>
opendatahub-io · Oct 9, 2024 · ef66506 · ef66506
1 parent c8d7822
commit ef66506
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/frontend/src/pages/modelServing/screens/projects/NIMServiceModal/NIMPVCSizeSection.tsx b/frontend/src/pages/modelServing/screens/projects/NIMServiceModal/NIMPVCSizeSection.tsx
@@ -1,6 +1,7 @@
 import React from 'react';
 import { HelperText, HelperTextItem, StackItem } from '@patternfly/react-core';
 import PVSizeField from '~/pages/projects/components/PVSizeField';
+import { MEMORY_UNITS_FOR_SELECTION } from '~/utilities/valueUnits';
 
 type NIMPVCSizeSectionProps = {
   pvcSize: string;
@@ -14,12 +15,16 @@ const NIMPVCSizeSection: React.FC<NIMPVCSizeSectionProps> = ({ pvcSize, setPvcSi
       size={pvcSize}
       setSize={(value: string) => setPvcSize(value)}
       label="NVIDIA NIM storage size"
+      options={MEMORY_UNITS_FOR_SELECTION.filter((option) => option.unit !== 'Mi')} // Filtering out 'Mi'
     />
     <HelperText>
       <HelperTextItem>
         Specify the size of the cluster storage instance that will be created to store the
         downloaded NVIDIA NIM.
       </HelperTextItem>
+      <HelperTextItem>
+        Make sure your storage size is greater than the NIM size specified by NVIDIA.
+      </HelperTextItem>
     </HelperText>
   </StackItem>
 );

diff --git a/frontend/src/pages/projects/components/PVSizeField.tsx b/frontend/src/pages/projects/components/PVSizeField.tsx
@@ -2,7 +2,7 @@ import * as React from 'react';
 import { FormGroup, FormHelperText, HelperText, HelperTextItem } from '@patternfly/react-core';
 import { ExclamationTriangleIcon } from '@patternfly/react-icons';
 import ValueUnitField from '~/components/ValueUnitField';
-import { MEMORY_UNITS_FOR_SELECTION } from '~/utilities/valueUnits';
+import { MEMORY_UNITS_FOR_SELECTION, UnitOption } from '~/utilities/valueUnits';
 
 type PVSizeFieldProps = {
   fieldID: string;
@@ -11,6 +11,7 @@ type PVSizeFieldProps = {
   setSize: (size: string) => void;
   currentSize?: string;
   label?: string;
+  options?: UnitOption[];
 };
 
 const PVSizeField: React.FC<PVSizeFieldProps> = ({
@@ -20,6 +21,7 @@ const PVSizeField: React.FC<PVSizeFieldProps> = ({
   setSize,
   currentSize,
   label = 'Persistent storage size',
+  options = MEMORY_UNITS_FOR_SELECTION,
 }) => (
   <FormGroup label={label} fieldId={fieldID} data-testid={fieldID}>
     <ValueUnitField
@@ -28,7 +30,7 @@ const PVSizeField: React.FC<PVSizeFieldProps> = ({
       menuAppendTo={menuAppendTo}
       onChange={(value) => setSize(value)}
       validated={currentSize ? 'warning' : 'default'}
-      options={MEMORY_UNITS_FOR_SELECTION}
+      options={options}
       value={size}
     />
     {currentSize && (