-
Notifications
You must be signed in to change notification settings - Fork 163
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
support feature flag overrides via query string
- Loading branch information
1 parent
1c5b791
commit f99a00b
Showing
53 changed files
with
667 additions
and
67 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
frontend/src/api/prometheus/__tests__/usePrometheusQuery.spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
frontend/src/api/prometheus/__tests__/usePrometheusQueryRange.spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,103 @@ | ||
import { Banner, Button, Checkbox, Grid, GridItem, Modal } from '@patternfly/react-core'; | ||
import * as React from 'react'; | ||
import { allFeatureFlags } from '~/concepts/areas/const'; | ||
import { isFeatureFlag } from '~/concepts/areas/utils'; | ||
import { DashboardCommonConfig } from '~/k8sTypes'; | ||
import { DevFeatureFlags } from '~/types'; | ||
|
||
type Props = { dashboardConfig: Partial<DashboardCommonConfig> } & DevFeatureFlags; | ||
|
||
const DevFeatureFlagsBanner: React.FC<Props> = ({ | ||
dashboardConfig, | ||
devFeatureFlags, | ||
setDevFeatureFlag, | ||
resetDevFeatureFlags, | ||
setDevFeatureFlagQueryVisible, | ||
}) => { | ||
const [isModalOpen, setModalOpen] = React.useState(false); | ||
|
||
if (!devFeatureFlags) { | ||
return null; | ||
} | ||
|
||
const renderDevFeatureFlags = () => ( | ||
<Grid hasGutter span={6} md={3}> | ||
{allFeatureFlags | ||
.filter(isFeatureFlag) | ||
.toSorted() | ||
.map((key) => { | ||
const value = devFeatureFlags[key] ?? dashboardConfig[key]; | ||
return ( | ||
<React.Fragment key={key}> | ||
<GridItem> | ||
<Checkbox | ||
id={key} | ||
data-testid={`${key}-checkbox`} | ||
label={key} | ||
isChecked={value ?? null} | ||
onChange={(_, checked) => { | ||
setDevFeatureFlag(key, checked); | ||
}} | ||
/> | ||
</GridItem> | ||
<GridItem data-testid={`${key}-value`}>{`${value ?? ''}${ | ||
key in devFeatureFlags ? ' (overridden)' : '' | ||
}`}</GridItem> | ||
</React.Fragment> | ||
); | ||
})} | ||
</Grid> | ||
); | ||
return ( | ||
<> | ||
<Banner variant="blue"> | ||
Feature flags are{' '} | ||
<Button | ||
data-testid="override-feature-flags-button" | ||
variant="link" | ||
isInline | ||
onClick={() => { | ||
setModalOpen(true); | ||
setDevFeatureFlagQueryVisible(true); | ||
}} | ||
> | ||
overridden | ||
</Button>{' '} | ||
in the current session.{' '} | ||
<Button | ||
data-testid="reset-feature-flags-button" | ||
variant="link" | ||
isInline | ||
onClick={resetDevFeatureFlags} | ||
> | ||
Click here | ||
</Button>{' '} | ||
to reset back to defaults. | ||
</Banner> | ||
<Modal | ||
data-testid="dev-feature-flags-modal" | ||
variant="large" | ||
title="Feature flags" | ||
isOpen={isModalOpen} | ||
onClose={() => { | ||
setModalOpen(false); | ||
setDevFeatureFlagQueryVisible(false); | ||
}} | ||
actions={[ | ||
<Button | ||
data-testid="reset-feature-flags-modal-button" | ||
key="confirm" | ||
variant="link" | ||
onClick={() => resetDevFeatureFlags()} | ||
> | ||
Reset to defaults | ||
</Button>, | ||
]} | ||
> | ||
{renderDevFeatureFlags()} | ||
</Modal> | ||
</> | ||
); | ||
}; | ||
|
||
export default DevFeatureFlagsBanner; |
Oops, something went wrong.