Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story]: Display lack of accelerator recommendations in column #2056

Closed
Gkrumbach07 opened this issue Nov 2, 2023 · 9 comments · Fixed by #2077
Closed

[Story]: Display lack of accelerator recommendations in column #2056

Gkrumbach07 opened this issue Nov 2, 2023 · 9 comments · Fixed by #2077
Assignees
Labels
feature/accelerator-support All things related to Accelerators kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.

Comments

@Gkrumbach07
Copy link
Member

Gkrumbach07 commented Nov 2, 2023

Goal

Find an alternative to "disabling a label" to signify lack of accelerator recommendations in column

Dependency issue

Itemized goals

In the current mocks for Habana part 2, the label "Create profile" button is disabled for images that lack the recommend accelerators annotation. This is not possible in PF.

Screenshot 2023-11-02 at 6 17 49 PM

Aspects continued elsewhere

No response

Mocks

No mocks

@Gkrumbach07 Gkrumbach07 added priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. labels Nov 2, 2023
@DaoDaoNoCode DaoDaoNoCode added the feature/accelerator-support All things related to Accelerators label Nov 6, 2023
@Gkrumbach07
Copy link
Member Author

@yannnz I ran into this last week. Context for the problem is in the issue description

@yannnz
Copy link

yannnz commented Nov 7, 2023

Hi Gage, is it possible to use the compact filled grey label with icon to visually fake the disabled clickable label? PF compact filled label @Gkrumbach07

@Gkrumbach07
Copy link
Member Author

Gkrumbach07 commented Nov 7, 2023

Here is what it looks like @yannnz
Screenshot 2023-11-07 at 1 45 14 PM

@yannnz
Copy link

yannnz commented Nov 8, 2023

Here is what it looks like @yannnz Screenshot 2023-11-07 at 1 45 14 PM

Hmmm, is it possible to change the color of the icon and text to grey too?

@Gkrumbach07
Copy link
Member Author

Gkrumbach07 commented Nov 8, 2023

@yannnz that is the patternfly grey. The other option is to manually set the css, but we should avoid doing that if possible

@yannnz
Copy link

yannnz commented Nov 8, 2023

@yannnz that is the patternfly grey. The other option is to manually set the css, but we should avoid doing that if possible

I see. I checked with the PF team today, here is the suggestion of how to disable the editable label and what are the limitation of the approach: https://patternfly.slack.com/archives/C293LQ36J/p1699429646350539

If it is not a good approach from the development perspective, I think it is fine to just leave it as black at least the user will see the label and the tooltip to understand how to enable that function. WDYT @Gkrumbach07

@Gkrumbach07
Copy link
Member Author

Gkrumbach07 commented Nov 8, 2023

I see. I checked with the PF team today, here is the suggestion of how to disable the editable label and what are the limitation of the approach: https://patternfly.slack.com/archives/C293LQ36J/p1699429646350539

This is a PF5 solution and even then it is not perfect. disabling doesnt seem to change the color at all. I think the problem is that labels are not meant to be used as buttons. They can be external links, or can be edited, but not as a button

@yannnz

@yannnz
Copy link

yannnz commented Nov 9, 2023

I see. I checked with the PF team today, here is the suggestion of how to disable the editable label and what are the limitation of the approach: https://patternfly.slack.com/archives/C293LQ36J/p1699429646350539

This is a PF5 solution and even then it is not perfect. disabling doesnt seem to change the color at all. I think the problem is that labels are not meant to be used as buttons. They can be external links, or can be edited, but not as a button

@yannnz

Eric replied and said he can help on the disabling style with PF V4.: https://patternfly.slack.com/archives/C293LQ36J/p1699464992885189?thread_ts=1699429646.350539&cid=C293LQ36J
Would it help the issue we have here? In the PF doc, the Label can be used to trigger a modal or dropdown, though it is a different use case as we have here to navigate to a different page: https://v4-archive.patternfly.org/v4/components/label-group/react-demos#editable-labels-with-add-modal

@Gkrumbach07

@Gkrumbach07 Gkrumbach07 linked a pull request Nov 13, 2023 that will close this issue
7 tasks
@Gkrumbach07
Copy link
Member Author

We landed on this UX

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/accelerator-support All things related to Accelerators kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
Status: Done
Status: No status
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants