Added accelerator column and field

[Gkrumbach07]

closes: #1439
closes: #2056

Description

• Added accelerators column to image admin page
  • each row matches to what accelerator profiles exist in the cluster
  • pending UX issue for when an image does not have the "recommended accelerators" annotation
  • a button that navigates with state of identifier to the create accelerator profile page
• multi select input value for accelerator identifiers
  • this uses the identifiers from all accelerator profiles found to populate the dropdown
• navigate to create page when clicking "Create accelerator"

When clicking on "Create profile"
multiple identifiers

one identifier

How Has This Been Tested?

1. create a accelerator profile CR
2. open BYON import modal
3. fill in required fields
4. open dropdown for accelerators
5. The accelerator profile identifier you just added should be there. select it
6. start typing a new identifier
7. select create
8. save form
9. edit new image just created
10. see that identifiers are there
11. remove and add a new identifier
12. repeat steps 9 and 10

Test Impact

Tests are added to the existing image admin page test suite. Specifically testing

• ability to see accelerator profile display names when there is a match in the table
• able to sort accelerator column
• import modal's accelerator identifier multi select can select, create, and remove from the input
• edit modal has identifier info when present in the image annotations

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

[Gkrumbach07]

@yannnz This does not look like the mocks completely because of the following

• BYON enhancements phase 2 has a lot of overlap with this PR and @andrewballantyne is looking into the impact of adding some of the BYON features to this PR. Examples would be: including OOTB images, import/edit page layout
• specifically in the import/edit modal for a image. You used multiple single select fields with chips. so i used the patternfly multiselect. Let me know if you intended for there to be multiple single selects and i can change it to that flow instead

[Gkrumbach07]

@kaedward I think you looked at most of the wording already. but just in case i will give you a tag

[yannnz]

@yannnz This does not look like the mocks completely because of the following

• BYON enhancements phase 2 has a lot of overlap with this PR and @andrewballantyne is looking into the impact of adding some of the BYON features to this PR. Examples would be: including OOTB images, import/edit page layout
• specifically in the import/edit modal for a image. You used multiple single select fields with chips. so i used the patternfly multiselect. Let me know if you intended for there to be multiple single selects and i can change it to that flow instead
  @Gkrumbach07

1. Is it saying that when we are working on adding the BYON features, we will adapt to the new import/edit page layout? e.g. uses page rather than model for the import/edit.

2. In the screenshot, the identifier multiselect dropdown looks good to me. Is there a way to display a long identifier? I think PF default it as truncated chip and allow a tooltip when mouse hover.

.

3. Same comment for the tooltip next to the question icon. I think we will need popover for this case.

[Gkrumbach07]

@yannnz

1. Thats unclear to me. I dont know whats in byon 2 and whats not. The goal of this feature was to not cause any blockers for that future work
2. Already supported
   
3. I switched this over to tooltip

[Gkrumbach07]

@yannnz one more thing now that the other PR merged. This is what you had in the mocks. Look alright still?

When clicking on "Create profile"
multiple identifiers

one identifier

[christianvogt]

/approve

Tested various scenarios.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[christianvogt]

/lgtm

[dpanshug]

/lgtm