Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Add spinner and change logic In Model Serving Global Page #2135

Closed
1 task done
DaoDaoNoCode opened this issue Nov 13, 2023 · 2 comments · Fixed by #2176
Closed
1 task done

[Bug]: Add spinner and change logic In Model Serving Global Page #2135

DaoDaoNoCode opened this issue Nov 13, 2023 · 2 comments · Fixed by #2176
Assignees
@DaoDaoNoCode
Labels
feature/model-serving Model Serving Feature kind/bug Something isn't working priority/normal An issue with the product; fix when possible rhods-2.5

Comments

@DaoDaoNoCode
Copy link
Member

DaoDaoNoCode commented Nov 13, 2023 •
edited by lucferbux
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Deploy type

Installing Dashboard directly (eg. v2.12.0, commit xyz, branch name)

Version

main

Current Behavior

It takes a long time to load when you switch between projects so you will probably see an empty state flickering when you do it. Especially when you switch from a specific project to "All projects".

Expected Behavior

There should be loading state when you switch between projects

Steps To Reproduce

  1. Go to the global model serving page
  2. Select a project
  3. Switch back to "All projects"
  4. Look carefully at how the empty state changes and re-rendering

Workaround (if any)

No response

What browsers are you seeing the problem on?

No response

Anything else

No response
@DaoDaoNoCode DaoDaoNoCode added kind/bug Something isn't working untriaged Indicates the newly create issue has not been triaged yet priority/normal An issue with the product; fix when possible labels Nov 13, 2023
@lucferbux lucferbux self-assigned this Nov 15, 2023
@lucferbux
Copy link
Contributor

I'm investigating the issue right now

@andrewballantyne andrewballantyne added feature/model-serving Model Serving Feature and removed untriaged Indicates the newly create issue has not been triaged yet labels Nov 15, 2023
@DaoDaoNoCode DaoDaoNoCode mentioned this issue Nov 15, 2023
Merged
7 tasks
@lucferbux lucferbux mentioned this issue Nov 16, 2023
Closed
@lucferbux
Copy link
Contributor

@vconzola we can talke here about the loading indicator between project switches.

@lucferbux lucferbux mentioned this issue Nov 16, 2023
Closed
7 tasks
@DaoDaoNoCode DaoDaoNoCode mentioned this issue Nov 16, 2023
Merged
7 tasks
@lucferbux lucferbux changed the title [Bug]: Performance problem on global model serving page [Bug]: Add spinner and change logic In Model Serving Global Page Nov 17, 2023
@lucferbux lucferbux assigned DaoDaoNoCode and unassigned lucferbux Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DaoDaoNoCode DaoDaoNoCode

Labels
feature/model-serving Model Serving Feature kind/bug Something isn't working priority/normal An issue with the product; fix when possible rhods-2.5
Projects
Internal tracking
Status: Done
ODH Dashboard Planning
Archived in project
Milestone
No milestone
3 participants
@andrewballantyne @lucferbux @DaoDaoNoCode