Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance issues in model serving global context #2173

Closed
wants to merge 1 commit into from

Conversation

lucferbux
Copy link
Contributor

@lucferbux lucferbux commented Nov 16, 2023

Description

Closes #2177

How Has This Been Tested?

  1. Deploy several models in several projects
  2. Switch between projects
  3. Check the current network calls

Test Impact

[TODO]

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

openshift-ci bot commented Nov 16, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lucferbux. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lucferbux lucferbux added the do-not-merge/hold This PR is hold for some reason label Nov 16, 2023
@lucferbux
Copy link
Contributor Author

I still need to implement the ui element to avoid flickering, @vconzola any idea what should we use here, maybe a spinner?

@andrewballantyne
Copy link
Member

I still need to implement the ui element to avoid flickering, @vconzola any idea what should we use here, maybe a spinner?

@lucferbux Use a spinner, it's what we are doing in Pipelines and should be fine for the first pass here.

@vconzola
Copy link

@lucferbux I haven't see the behavior you're talking about, so waht @andrewballantyne said sounds good to me.

@lucferbux lucferbux linked an issue Nov 17, 2023 that may be closed by this pull request
1 task
@lucferbux
Copy link
Contributor Author

@andrewballantyne @vconzola I've created #2177 to continue the conversation about this, I still think that we should hide the "All projects" view from permissionless users, but that's something we might wanna talk with PM, in the meantime maybe we can get a workaround for this. But I'm gonna let this slip till next week

@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Dec 4, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lucferbux lucferbux closed this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold This PR is hold for some reason needs-rebase PR needs to be rebased
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Performance issue in Model Serving Global
4 participants