Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Cleanup caikit ootb runtime #2143

Closed
1 task done
andrewballantyne opened this issue Nov 14, 2023 · 2 comments · Fixed by #2147
Closed
1 task done

[Bug]: Cleanup caikit ootb runtime #2143

andrewballantyne opened this issue Nov 14, 2023 · 2 comments · Fixed by #2147
Assignees
Labels
feature/model-serving Model Serving Feature kind/bug Something isn't working priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. rhods-2.5

Comments

@andrewballantyne
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Deploy type

Installing Dashboard directly (eg. v2.12.0, commit xyz, branch name)

Version

main

Current Behavior

A little bit of a cleanup still needed for the caikit-ootb.yaml.

Expected Behavior

Add an additional env var in caikit-ootb.yaml

Expected output:

        env:
          - name: RUNTIME_LOCAL_MODELS_DIR
            value: /mnt/models
          - name: RUNTIME_GRPC_SERVER_THREAD_POOL_SIZE
            value: 64

Remove ports name field in caikit-ootb.yaml as this will cause some issues with KServe.

Steps To Reproduce

Go to Settings => Serving Runtimes & view the YAML for the ootb caikit runtime

Workaround (if any)

No response

What browsers are you seeing the problem on?

No response

Anything else

No response

@andrewballantyne andrewballantyne added kind/bug Something isn't working untriaged Indicates the newly create issue has not been triaged yet priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. feature/model-serving Model Serving Feature rhods-2.5 labels Nov 14, 2023
@andrewballantyne
Copy link
Member Author

cc @lucferbux @Xaenalt

@lucferbux lucferbux self-assigned this Nov 15, 2023
@lucferbux lucferbux mentioned this issue Nov 15, 2023
7 tasks
@DaoDaoNoCode DaoDaoNoCode removed the untriaged Indicates the newly create issue has not been triaged yet label Nov 22, 2023
@manosnoam
Copy link
Contributor

Verified on RHOAI 2.5:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/model-serving Model Serving Feature kind/bug Something isn't working priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. rhods-2.5
Projects
Status: No status
Status: No status
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants