-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup of caikit OOTB #2147
Cleanup of caikit OOTB #2147
Conversation
@andrewballantyne @Xaenalt This is the cleanup PR for caikit. The renaming of the file is not needed, since it's an internal file and there's no implication whatsoever to the final product. I can do it if you want but I don't see the need. |
8270754
to
f196f4d
Compare
f196f4d
to
d6c9fb0
Compare
maybe we could add the version metadata as well, otherwise user will see this in the UI: @Xaenalt does the runtime have a specific version? I would say we could review the need of |
/lgtm |
@lucferbux: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We can add that as a follow up! |
@lucferbux follow up issue: #2189 |
Description
Closes #2143
How Has This Been Tested?
oc apply -k manifests/modelserving
Test Impact
No testing involved
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main