-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If you delete a Pipeline, the run reference leads to a meaningful message #1497
Conversation
cc @kywalker-rh can you take a look? |
@pnaik1 can we not avoid the header "Loading..." & the action items in the top right? ... perhaps we can replace the title with something else? I wonder if the breadcrumbs have value to take you back... maybe we can look into using React Router to send us back to where we came from? This is a reasonable stop-gap though for showing an error screen like we did before. I suspect Kyle will know more of what we can do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
It seems weird to have the page still say "Loading...", my assumption from seeing this page is we are no longer loading, we've discovered it doesn't exist. So in that case we should simply call the page "Pipeline not found". If we can remember the pipeline name from the link we should make it "Pipeline ' Hopefully that is clear. Also, for the Actions button in the top right, we should simply disable it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we just simplify this and just show nothing but the 404?
Maybe we could mount the ApplicationPage, but make the body the 404 component you made. It would allow us to have some structure. Let me know if you want to talk about this.
I suggested two solutions as it really depends on how each looks. Maybe take screenshots of both or something.
frontend/src/concepts/pipelines/content/pipelinesDetails/pipeline/PipelineNotFound.tsx
Outdated
Show resolved
Hide resolved
@andrewballantyne we can have a look |
3a41056
to
150e6a7
Compare
@andrewballantyne So I made the changes as per your request this will also solve when we use the wrong template , even here we dont want the action button to be displayed |
I'm pretty sure "Wrong pipeline" is your name of a test pipeline, but just want to double check we're not telling a user they have a wrong pipeline. Also, I'm not totally following your thread, but if its significantly easier to simply not show the |
@kywalker-rh yeah the wrong pipeline is the pipeline name |
frontend/src/concepts/pipelines/content/pipelinesDetails/pipeline/PipelineDetails.tsx
Show resolved
Hide resolved
Looks good! Thanks for confirming the name. :) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, uidoyen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I have rebased the branch |
/lgtm |
Closes: #1324
Description
#1324
The page displays the correct error message and a link to navigate to pipeline page
How Has This Been Tested?
Test Impact
no test coverage
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main