Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes thanos-querier port configurable and sets bias queries to use OAuth Port #1503

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Makes thanos-querier port configurable and sets bias queries to use OAuth Port #1503

merged 1 commit into from
Jul 11, 2023

Conversation

alexcreasy
Copy link
Contributor

@alexcreasy alexcreasy commented Jul 11, 2023 •
edited
Loading

Fixes a bug with fetching bias metrics when deployed to an OpenShift cluster.

  • Makes the thanos-querier internal port configurable on the backend
  • Switches bias queries to use the OAuth port instead of the RBAC port.

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Jul 11, 2023
@alexcreasy alexcreasy changed the title WIP Makes thanos-querier port configurable and sets bias queries to use O… Makes thanos-querier port configurable and sets bias queries to use OAuth Port Jul 11, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Jul 11, 2023
DaoDaoNoCode
DaoDaoNoCode approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: DaoDaoNoCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit cfbe4f2 into opendatahub-io:f/mserving-metrics Jul 11, 2023
4 checks passed
alexcreasy added a commit to alexcreasy/odh-dashboard that referenced this pull request Jul 13, 2023
@alexcreasy
Revert "Merge pull request opendatahub-io#1503 from alexcreasy/config…
4a65305 
…urable-thanos-port"

This reverts commit cfbe4f2, reversing
changes made to 0683de3.
alexcreasy added a commit to alexcreasy/odh-dashboard that referenced this pull request Jul 17, 2023
@alexcreasy
Revert "Merge pull request opendatahub-io#1503 from alexcreasy/config…
fec931d 
…urable-thanos-port"

This reverts commit cfbe4f2, reversing
changes made to 0683de3.
alexcreasy added a commit to alexcreasy/odh-dashboard that referenced this pull request Jul 18, 2023
@alexcreasy
Revert "Revert "Merge pull request opendatahub-io#1503 from alexcreas…
9959d2d 
…y/configurable-thanos-port""

This reverts commit fec931d.
alexcreasy added a commit to alexcreasy/odh-dashboard that referenced this pull request Jul 18, 2023
@alexcreasy
Revert "Revert "Merge pull request opendatahub-io#1503 from alexcreas…
b758ee8 
…y/configurable-thanos-port""

This reverts commit fec931d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaoDaoNoCode DaoDaoNoCode DaoDaoNoCode approved these changes

@lucferbux lucferbux Awaiting requested review from lucferbux

Assignees

@DaoDaoNoCode DaoDaoNoCode

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexcreasy @DaoDaoNoCode @openshift-merge-robot