Notebook Spawner reachable when disabled

[pnaik1]

Closes: #1462

Description

#1462
Not to be able to find a route to the notebookController part of the app when it is disabled.

The empty state page

How Has This Been Tested?

Modifying the OdhDashboardConfig is required to test this.
Enable DS Projects spec.dashboardConfig.disableProjects = false
Disable NotebookController spec.notebookController.enable = false
You can see in DS project , you cannot find a route to notebookController

Test Impact

no test coverage

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

[andrewballantyne]

Navigate to the DS Projects view, and click on the launch notebook button (both empty state and list state has the button)

You only got half of this no 3 point from the issue. Please get the empty state too.

[pnaik1]

@andrewballantyne my bad , I totally missed it

[pnaik1]

@andrewballantyne made the changes

[andrewballantyne]

@andrewballantyne made the changes

@pnaik1 please update your description with another screenshot

[pnaik1]

@andrewballantyne updated with screenshot

[andrewballantyne]

@pnaik1 so you want to be on the lookout for text that is confusing if we don't have that functionality. We don't have Jupyter notebook and your screenshot says to the user they can use it -- which is not true.

@kywalker-rh @kaedward thoughts on the text -- We also have two sets of text, so I bet we need to update both scenarios (with and without self provision abilities).

[kywalker-rh]

Unless its disabled by something else, I think we should have the "Launch Jupyter" link button, then the text will make sense. Is it not included for a reason?

[andrewballantyne]

Unless its disabled by something else, I think we should have the "Launch Jupyter" link button, then the text will make sense. Is it not included for a reason?

@kywalker-rh this is the issue, #1462 -- If you disable the tile, we still link to it from DS Projects. This issue is addressing that gap. We shouldn't link to something if you disable the Jupyter Tile.

[kywalker-rh]

Thanks... now I know to click all the links in a PR. In this case I think we should simply remove the or launch a notebook with Jupyter text for both options of the page.

[pnaik1]

@andrewballantyne @kywalker-rh I have made the changes

[manaswinidas]

/lgtm

[andrewballantyne]

Das tested this... the code looks good to me.

I'm going to approve. My only remark is when we get to translations, we'll have to handle this text chunking better -- but that's an unknown distant future.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, manaswinidas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [andrewballantyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment