-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor BYON images table #1506
Refactor BYON images table #1506
Conversation
@vconzola Can you check the changes as it's shown in the screenshot? |
@DaoDaoNoCode Does this PR address including out-of-box images in the table - it doesn't look like it does? Will that be handled in a follow-up PR? Also, I don't see this spelled out in the issue requirements, but since we're not including click/drag yet, would it be a simple change (" one liner") to add sorting to the Enable column? That would allow users to see all of their enabled images at the top. |
{ | ||
field: 'enable', | ||
label: 'Enable', | ||
sortable: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it should be a one liner @vconzola haha.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only concerns are regarding pagination, how are we handling 20+ images without pagination?
name: string; | ||
url: string; | ||
description?: string; | ||
// FIXME: This shouldn't be a user defined value consumed from the request payload but should be a controlled value from an authentication middleware. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this taken care of already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet, I believe this part will be taken care of after we support OOTB images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we should be removing this comment then. If we are, we should be tracking it somewhere. Are we already tracking this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, i think we should just keep the comment here until we get to refactor the backend in phase 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please keep the comment then, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry my bad, I thought I didn't remove the comment 😞 I will add it back in the following PR, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
After the discussion with @vconzola , we are trying to keep the table as it was before - which means we will not add the pagination for now. |
Closes #1432
Description
useFetchState
hook to get BYON imagesHow Has This Been Tested?
Test Impact
TBD
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main