Revert configurable thanos port #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcreasy
requested review from
andrewballantyne
and removed request for
lucferbux and
DaoDaoNoCode
|
@andrewballantyne if you're OK with this - I'd like to just revert the problematic code now, rather than leave it on the branch until it's forgotten about, or becomes harder to remove. |
andrewballantyne
approved these changes
Jul 17, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit a020b53
into
opendatahub-io:f/mserving-metrics
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the PR allowing changing the port used to query Thanos metrics. The dashboard should only make RBAC queries and not OAuth queries (which the previous PR allowed). This is due to the Thanos OAuth proxy only allowing cluster-admin users to log in. Our dashboard must work for users with lower privileges as in a real world scenario no user will have that level of privilege for day to day work.