-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gracefully handle image packages and software JSON parse error #1553
Gracefully handle image packages and software JSON parse error #1553
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
1d7c081
to
8daf822
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#1553 Add check for stale data in session storage for selected bias charts
Close #1493
Description
After a discussion with the UX, we decide to parse the error dependency string as empty, which means when the parse error happens, the backend will return an empty array to the frontend side. So from the user's perspective, it can still normally use the image but see no dependencies in the image.
How Has This Been Tested?
annotation['opendatahub.io/notebook-python-dependencies']
of its tag to an invalid string which could cause the JSON parse errorTest Impact
N/A, it's just a parse error solved at the backend side
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main