Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle image packages and software JSON parse error #1553

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Jul 19, 2023

Close #1493

Description

After a discussion with the UX, we decide to parse the error dependency string as empty, which means when the parse error happens, the backend will return an empty array to the frontend side. So from the user's perspective, it can still normally use the image but see no dependencies in the image.

How Has This Been Tested?

  1. Go to the cluster, and find one image stream that the notebook controller spawner page could fetch
  2. Change the annotation['opendatahub.io/notebook-python-dependencies'] of its tag to an invalid string which could cause the JSON parse error
  3. Go to the notebook controller spawner page in the dashboard, see if you could successfully load the page and select the image
  4. Check the details of the image by clicking the tooltip next to it, and find if the packages are not visible in the details

Test Impact

N/A, it's just a parse error solved at the backend side

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 1, 2023
@Gkrumbach07
Copy link
Member

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f693c03 into opendatahub-io:main Aug 1, 2023
4 checks passed
openshift-ci bot added a commit that referenced this pull request Nov 1, 2023
#1553 Add check for stale data in session storage for selected bias charts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Dependency Annotations can blindly crash
5 participants