Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added accelerator detection #1628

Conversation

Gkrumbach07
Copy link
Member

closes: #1441

Description

adds accelerator detection by looking at cluster node resources. This creates a new /accelerators end point which returns a object with the available, allocated, and total number of accelerators.

How Has This Been Tested?

get a GPU cluster, call the new endpoint, test to see accelerators are detected

Test Impact

backend n/a

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@Gkrumbach07 Gkrumbach07 linked an issue Aug 1, 2023 that may be closed by this pull request
@Gkrumbach07 Gkrumbach07 mentioned this pull request Aug 1, 2023
7 tasks
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit dba676e into opendatahub-io:accelerator-support Aug 8, 2023
3 checks passed
@Gkrumbach07 Gkrumbach07 deleted the accelerator-detection branch August 10, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HBU/GPU detection in the backend
3 participants