Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: Workbench not editable for a little while after it's stopped #1631

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

alexcreasy
Copy link
Contributor

@alexcreasy alexcreasy commented Aug 3, 2023

Description

  • When stopping a workbench:
    • the switch now waits for the pods to spin down before showing status "stopped".
    • The edit button in the kebab is disabled until the new stopped status.

How Has This Been Tested?

  • Stop a running workbench
  • Wait for the edit button in the kebab to not be disabled
  • Make an update to your workbench, e.g. change the notebook image.
  • Ensure you do not see the error message reported in the bug.

Test Impact

None.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@lucferbux
Copy link
Contributor

/hold

We are gonna wait for next sprint on this one.

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Aug 9, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Aug 9, 2023
@lucferbux
Copy link
Contributor

/unhold

This might get into the release

@openshift-ci openshift-ci bot removed the do-not-merge/hold This PR is hold for some reason label Aug 9, 2023
@lucferbux
Copy link
Contributor

If you can rebase this @alexcreasy I'll do a review later today!

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and code looks good. Waiting for rebase

@alexcreasy
Copy link
Contributor Author

/hold

HOLD - due to ambiguity around what should be in the RHODS 1.32 release we're not merging anything until we have clarity.

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Aug 15, 2023
@alexcreasy
Copy link
Contributor Author

Rebased.

@Gkrumbach07
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 17, 2023
@alexcreasy alexcreasy removed the do-not-merge/hold This PR is hold for some reason label Aug 23, 2023
@christianvogt
Copy link
Contributor

tested
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4d40ad8 into opendatahub-io:main Aug 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Workbench not editable for a little while after it's stopped.
5 participants