-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make custom image location regex match return correct full URL #1642
Make custom image location regex match return correct full URL #1642
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@DaoDaoNoCode have you built this and tested it on a cluster? |
@alexcreasy yes, I did that the last moment before my demo started :P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built an image and tested on my cluster, works great!
Then pls tick the box from the template :) |
/approved |
@alexcreasy Ah because it's not going to |
@DaoDaoNoCode yeah, good point, I'll create a new template for going to incubation tomorrow morning my time! |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: alexcreasy, lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
41a14f5
into
opendatahub-io:incubation
Closes #1641
Description
It's because the image regex is returning the full match result as the URL but not the full URL, so the tag is omitted.
How Has This Been Tested?
Follow the same way in the issue description:
quay.io/opendatahub/workbench-images@sha256:b6532b34c9bf0710ecbd76407c8909742914bdacd17add3e04ab49e7c81a2800
Test Impact
N/A
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main