Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make custom image location regex match return correct full URL #1642

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Aug 7, 2023

Closes #1641

Description

It's because the image regex is returning the full match result as the URL but not the full URL, so the tag is omitted.

How Has This Been Tested?

Follow the same way in the issue description:

  1. Go to Notebook image settings
  2. Try to import an image using SHA256-encoded tag like quay.io/opendatahub/workbench-images@sha256:b6532b34c9bf0710ecbd76407c8909742914bdacd17add3e04ab49e7c81a2800
  3. Make sure the image can be successfully imported and the image location is shown correctly

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@DaoDaoNoCode DaoDaoNoCode linked an issue Aug 7, 2023 that may be closed by this pull request
1 task
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@alexcreasy
Copy link
Contributor

@DaoDaoNoCode have you built this and tested it on a cluster?

@DaoDaoNoCode
Copy link
Member Author

@alexcreasy yes, I did that the last moment before my demo started :P

Copy link
Contributor

@alexcreasy alexcreasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built an image and tested on my cluster, works great!

@alexcreasy
Copy link
Contributor

@alexcreasy yes, I did that the last moment before my demo started :P

Then pls tick the box from the template :)

@alexcreasy
Copy link
Contributor

/approved

@DaoDaoNoCode
Copy link
Member Author

@alexcreasy Ah because it's not going to main, it's going to incubation

@alexcreasy
Copy link
Contributor

@alexcreasy Ah because it's not going to main, it's going to incubation

@DaoDaoNoCode yeah, good point, I'll create a new template for going to incubation tomorrow morning my time!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: alexcreasy, lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 41a14f5 into opendatahub-io:incubation Aug 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot use SHA256 as the image tag
4 participants