Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accelerator support update to match incubation #1656

Conversation

Gkrumbach07
Copy link
Member

Description

Merge incubation into feature branch

How Has This Been Tested?

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

andrewballantyne and others added 30 commits March 16, 2023 13:55
* Rework Inference Metrics & Add Runtime Metrics (invalid quieries)

* Add stacked line chart functionality
* Explainability: Fairness and Bias Metrics (Phase 0) (opendatahub-io#1001) (opendatahub-io#1006) (opendatahub-io#1007) (opendatahub-io#1008)
  - Initial feature set for TrustyAI related UI functionality
  - Adds tab based navigation to modelServing screen
  - Adds a bias metrics tab with charts for visualising SPD and DIR metrics
  - Enhances prometheus query features for accessing TrustyAI data
  - Enhacements to MetricsChart component making it more configurable

* Update key of request name to match trusty backend

* Remove unnecessary div and inline style from tooltip

* Remove 15 minutes refresh option

* Prefer optional prop to type union with undefined

* Move function definitions inline

* Prefer narrowing over type conversion

* Inline tab change handler

* Remove toolbar option from ApplicationsPage

* Inline domain calculator functions

* Move defaultDomainCalculator to utils

* Return null instead of undefined

* Use threshold label instead of index for key

* Add enum for tab keys

* Remove magic numbers from domain calculations

* Make ResponsePredicate mandatory and add predicate to useQueryRangeResourceData
* Add support for insecure http requests in development mode

* Adds low level API client for TrustyAI service

* Adds TrustyAI high level API and contexts

* Get scheme of TrustyAI route from k8s data
* Add model bias configuration table

* rebase and remove mock data
* Add configuration modal

* address comments

* get rid of some TODOs and refine the route
…datahub-io#1349)

* Enhancements to model bias screen

  * Display of multiple bias charts simultaneously

  * Multi-select component, allowing free text, or select-from-list selection of chartst to display

  * Ability to collapse / expand individual charts

  * User selectable refresh rates of chart data

  * Chart selection and open / closed status is persisted to session cache for life of user's browser session

Display user defined threshold values on charts (opendatahub-io#1163)

  * Clean up of bias chart logic

  * Displays thresholds chosen by user, or defaults if none.

  * Improves domain and threshold calculation based on user values or defaults
* Fix metrics submission issue and handle errors

* fix lint issue

* use error handler on GET functions
…and set feature flag (opendatahub-io#1390)

* Default and restrict threshold, add tooltips, default duplicate name and set feature flag

* fix lint

* add tooltips and dropdown descriptions

* clear data when closing configuration modal

* really solve deleting issue, make empty table view a common component and apply it everywhere

* address comments
…o#1399)

* Adds refresh interval options that match openshift observability dashboard

* Show first chart from list, if none selected when user first navigates to bias tab

* Use search icon instead of plus for nothing selected empty state

* Fix error with calculation of 30 days constant

* Deleted charts are removed from session storage
…ahub-io#1403) (opendatahub-io#1404)

* Refactor prometheus queries to remove duplication

* Fix graph not refreshing issue

* Add code review suggestions
opendatahub-io#1413)

* Add performance metrics feature flag, refactor runtime server route and solve layout issues

* revert some style changes
* revert table changes

* experiments table added

update linting, add label, fix create

cleaned up table logic

fixed stale data

* fixed job form add exp wait
* Adds support for TrustyAI Operator (opendatahub-io#1276)

* Changes from feedback
* Test serving runtime

* Refactor custom serving runtimes enablement

* Remove tensorflow from ootb

* Add startup function to migrate disablement status for Custom Serving Runtime

* Fix feedback

* Delete unused annotations

* Fix feedback

* Remove templates from disablement list when deleted

* Fix issue filtering serving runtimes
* Re-enable Metrics

* Fix Graphs & Configure Infrastructure (opendatahub-io#1023)

* Rework Inference Metrics & Add Runtime Metrics (invalid quieries)

* Add stacked line chart functionality

* Trustyai demo phase0 (opendatahub-io#1093)

* Explainability: Fairness and Bias Metrics (Phase 0) (opendatahub-io#1001) (opendatahub-io#1006) (opendatahub-io#1007) (opendatahub-io#1008)
  - Initial feature set for TrustyAI related UI functionality
  - Adds tab based navigation to modelServing screen
  - Adds a bias metrics tab with charts for visualising SPD and DIR metrics
  - Enhances prometheus query features for accessing TrustyAI data
  - Enhacements to MetricsChart component making it more configurable

* Update key of request name to match trusty backend

* Remove unnecessary div and inline style from tooltip

* Remove 15 minutes refresh option

* Prefer optional prop to type union with undefined

* Move function definitions inline

* Prefer narrowing over type conversion

* Inline tab change handler

* Remove toolbar option from ApplicationsPage

* Inline domain calculator functions

* Move defaultDomainCalculator to utils

* Return null instead of undefined

* Use threshold label instead of index for key

* Add enum for tab keys

* Remove magic numbers from domain calculations

* Make ResponsePredicate mandatory and add predicate to useQueryRangeResourceData

* TrustyAI Client (opendatahub-io#1318)

* Add support for insecure http requests in development mode

* Adds low level API client for TrustyAI service

* Adds TrustyAI high level API and contexts

* Get scheme of TrustyAI route from k8s data

* Add model bias configuration table (opendatahub-io#1290)

* Add model bias configuration table

* rebase and remove mock data

* Update Trusty AI client to handle API changes (opendatahub-io#1336) (opendatahub-io#1337)

* Add bias metrics configuration modal (opendatahub-io#1343)

* Add configuration modal

* address comments

* get rid of some TODOs and refine the route

* Multi-metric display on model bias screen (opendatahub-io#1273) (opendatahub-io#1349)

* Enhancements to model bias screen

  * Display of multiple bias charts simultaneously

  * Multi-select component, allowing free text, or select-from-list selection of chartst to display

  * Ability to collapse / expand individual charts

  * User selectable refresh rates of chart data

  * Chart selection and open / closed status is persisted to session cache for life of user's browser session

Display user defined threshold values on charts (opendatahub-io#1163)

  * Clean up of bias chart logic

  * Displays thresholds chosen by user, or defaults if none.

  * Improves domain and threshold calculation based on user values or defaults

* Fix metrics submission issue and handle errors (opendatahub-io#1378)

* Fix metrics submission issue and handle errors

* fix lint issue

* use error handler on GET functions

* Default and restrict threshold, add tooltips, default duplicate name and set feature flag (opendatahub-io#1390)

* Default and restrict threshold, add tooltips, default duplicate name and set feature flag

* fix lint

* add tooltips and dropdown descriptions

* clear data when closing configuration modal

* really solve deleting issue, make empty table view a common component and apply it everywhere

* address comments

* Minor enhancements to bias chart (opendatahub-io#1386) (opendatahub-io#1399)

* Adds refresh interval options that match openshift observability dashboard

* Show first chart from list, if none selected when user first navigates to bias tab

* Use search icon instead of plus for nothing selected empty state

* Fix error with calculation of 30 days constant

* Deleted charts are removed from session storage

* Fixes issue with bias charts auto-refreshing with stale data (opendatahub-io#1403) (opendatahub-io#1404)

* Refactor prometheus queries to remove duplication

* Fix graph not refreshing issue

* Add code review suggestions

* Add performance metrics feature flag and refactor runtime server route (opendatahub-io#1413)

* Add performance metrics feature flag, refactor runtime server route and solve layout issues

* revert some style changes

* Model serving metrics renaming (opendatahub-io#1421)

* Adds support for TrustyAI Operator (opendatahub-io#1443)

* Adds support for TrustyAI Operator (opendatahub-io#1276)

* Changes from feedback

---------

Co-authored-by: Andrew Ballantyne <[email protected]>
Co-authored-by: Andrew Ballantyne <[email protected]>
Co-authored-by: Alex Creasy <[email protected]>
Co-authored-by: Alex Creasy <[email protected]>
* Add 'Edit Permissions' Kebab to Project Row

* chore: Some nitpick
DaoDaoNoCode and others added 23 commits July 31, 2023 10:53
…ue-1433

Update modals and generate meaningful k8s name for images
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.6.0 to 3.7.0.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v3.6.0...v3.7.0)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…ue-1493

Gracefully handle image packages and software JSON parse error
…/github_actions/main/actions/setup-node-3.7.0

Bump actions/setup-node from 3.6.0 to 3.7.0
update architecture doc folder structure
…size_to_20Gi

change const DEFAULT_PVC_SIZE from 20 to 20Gi as in frontend notebook const ts
…-overlay

Add performance overlay and sync deployment to odh-manifest
…oy-model

handle white space in creation and deletion using display names
Parameters from triggered runs not copied when run is duplicated
Merge main into incubation and prepare for release
…ue-1641

Make custom image location regex match return correct full URL
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andrewballantyne for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Gkrumbach07 Gkrumbach07 changed the title Accelerator support Accelerator support update to match incubation Aug 10, 2023
@Gkrumbach07 Gkrumbach07 deleted the branch opendatahub-io:accelerator-support August 10, 2023 15:24
@Gkrumbach07 Gkrumbach07 deleted the accelerator-support branch August 10, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.