Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make notebook controller access button to link behavior #1675

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ export const NotebookServer: React.FC = () => {
[requestNotebookRefresh, navigate],
);

const link = notebook?.metadata.annotations?.['opendatahub.io/link'] || '#';

return (
<>
<ImpersonateAlert />
Expand All @@ -54,18 +56,17 @@ export const NotebookServer: React.FC = () => {
/>
<ActionList>
<ActionListItem
onClick={() => {
if (notebook.metadata.annotations?.['opendatahub.io/link']) {
window.location.href = notebook.metadata.annotations['opendatahub.io/link'];
} else {
onClick={(e) => {
if (link === '#') {
DaoDaoNoCode marked this conversation as resolved.
Show resolved Hide resolved
e.preventDefault();
notification.error(
'Error accessing notebook server',
'Failed to redirect page due to missing notebook URL, please try to refresh the page and try it again.',
);
}
}}
>
<Button data-id="return-nb-button" variant="primary">
<Button component="a" href={link} data-id="return-nb-button">
Access notebook server
</Button>
</ActionListItem>
Expand Down
Loading