Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused frontend source code files #1687

Merged

Conversation

christianvogt
Copy link
Contributor

@christianvogt christianvogt commented Aug 21, 2023

Related to: #1620

Description

Ran knip on the following branches:

  • main
  • incubation
  • accelerator-support
  • f/byon
  • f/mserving-metrics
  • f/pipeline-enhancements
  • f/pipeline-experiments

The following files were not used by any branch:

@andrewballantyne @lucferbux @DaoDaoNoCode let me know if any of these files are worth keeping

@andrewballantyne
Copy link
Member

andrewballantyne commented Aug 25, 2023

The following files were not used by any branch:

  • src/components/FormGroupSettings.tsx

Hah -- seems to have been a refactor without properly cleaning up the old file. The new one seems to be frontend/src/pages/groupSettings/GroupSettings.tsx

✅ This can be deleted

  • src/concepts/pipelines/content/configurePipelinesServer/DatabaseConnectionInputField.tsx

This seems to be contributed by the effort we originally did for Pipeline Server... I recall us pivoting a lot on how this was done. This is handled via frontend/src/concepts/pipelines/content/configurePipelinesServer/DatabaseConnectionField.tsx

✅ This can be deleted

  • src/concepts/secrets/apiHooks/useSecret.ts

Looks like this is related to useAWSSecret -- likely we had limited logic at the start and needed to improve this. This is not needed today. DS Projects (DS Grouping) was under a lot of time pressure and we did a lot of corner cutting.

Seems like this may have been a merge conflict in the DS Pipelines branch. Deleted in main, readded back by a merge conflict resolution 🤔

✅ This can be deleted

  • src/pages/projects/screens/spawner/storage/useNotebookRootStorage.ts

Most interesting... this was likely created in a PR for managing SpawnerPage state -- but was tossed when I probably made a comment. The effort behind this is covered via other means, no need to keep it around.

✅ This can be deleted

  • src/pages/projects/typeHelpers.ts

Hah, impressive -- this was the original location for helpers -- which was crafted during the DS Projects work ... but it was moved to the root as it was nothing to do with Projects directly.

✅ This can be deleted

  • src/utilities/useDebounce.ts

I recall this being part of the work for Summit -- I recall it being created for some reason... seems it was eventually no longer needed. @DaoDaoNoCode & @lucferbux worked on that feature and I didn't see much of it until the end.

✅ This can be deleted

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1944830 into opendatahub-io:main Aug 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants