Add empty state when no serving platform is enabled #2109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1994
Closes #1995
Description
There are several checks in this PR:
When the platforms are installed:
When we enter an unlabelled project and both
disableKServe
anddisableModelMesh
feature flags are set totrue
, you will get the empty state to tell you to ask for the administrator to enable platform selection.When either platform is not installed:
On the cluster settings page:
DataScienceCluster
resource page on the OpenShift consoleDataScienceCluster
, the link button will be a plain textOn project details page:
If the project is labeled already but the serving platform in not installed at all, you will see a loading error
When both platforms are not installed:
You will see an error page on the global model serving page:
Of course, the cluster settings page grey both of them out because we only hide this section when you fully disable model serving.
How Has This Been Tested?
There are several parts of this:
First part:
Second part:
Managed
toRemoved
, making sure the status changed tofalse
, which means that platform is not available anymoreDataScienceCluster
resourceThird part:
Test Impact
Update some feature flag related tests, and add an integration test to test the empty state.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main