Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Edge MVP Sidebar, Emptystate and Add model #2110

Closed

Conversation

Sara4994
Copy link

@Sara4994 Sara4994 commented Nov 9, 2023

Description

How Has This Been Tested?

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Nov 9, 2023
Copy link
Contributor

openshift-ci bot commented Nov 9, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign alexcreasy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Nov 9, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label Nov 9, 2023
@Gkrumbach07 Gkrumbach07 changed the title Edge MVP Sidebar, Emptystate and Add model [WIP] Edge MVP Sidebar, Emptystate and Add model Nov 9, 2023
@Sara4994 Sara4994 marked this pull request as ready for review November 9, 2023 17:41
@Gkrumbach07
Copy link
Member

@Sara4994
Here is what i think you need to do for this PR.

  1. make sure you are filling in all the PR template criteria before you post the PR. We try to keep things out of WIP/draft unless there is a good reason for it
  2. This PR should not be going into main. This should be going into the feature branch as described by the tracker
  3. what issues is this closing? all PRs must have a linked issue. I think this is covering multiple issues so i would suggest you open a separate PR for each issue. This will benefit development in a few ways
    • we wont get ahead of ourselves and start work when previous foundation work is not ready. The issues in the tracker for this feature have dependencies, meaning we should not start the issue until we land all of its parent issues.
    • smaller PRs: its easier to review smaller PRs, the reason we split the tracker into multiple issues is so that we can have multiple PRs. It makes us less likely to miss bugs.

@Sara4994 Sara4994 closed this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress This PR is in WIP state
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants