Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge f/ds-projects to main #2118

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Nov 10, 2023

Closes #1924

Description

Add 2 new features:

  1. Now users can see all available projects on the cluster on the data science projects page. They can do so by changing the selection dropdown
  2. Now the cluster storage supports units, and the error handling is improved

How Has This Been Tested?

For data science projects page change:

  1. Go to the data science projects page
  2. You will see a dropdown below the title, which you can choose the scope
  3. Try to change the scope to see if you can see other OpenShift projects on the cluster
  4. Make sure the search and filter is not broken

For cluster storage change:

  1. Go to the project details page
  2. Try to create a workbench with a cluster storage, you can now select the storage unit (Gi or Mi)
  3. After creation, try to edit the storage to a smaller value (for example, you create a 2Gi storage, and edit it to 2000Mi), then you should be able to see the error message when you try to update the storage size
  4. Try to edit the storage to a larger size, it should be working
  5. Create a storage without connecting it to any workbench
  6. Try to change the size, it should prompt an error message telling you you cannot change the size of an unbound storage

Test Impact

Added the integration test to verify it could correctly show the corresponding scope (DS projects or all projects).
Added unit tests to verify the filter function could filter out some system/default projects that we don't want to show.
Storage part tests not added because we need that for e2e tests, not for now.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@alexcreasy
Copy link
Contributor

Code looks good, tested and works aside from one small bug with filtering. @DaoDaoNoCode will create a ticket and raise a PR for the bug separately. Otherwise we are good to go to hit feature freeze.

/approve

Copy link
Contributor

openshift-ci bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexcreasy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Gkrumbach07
Copy link
Member

looks good. Just one question. if i create an unbound storage and then attach it to a workbench after creation. i still cant increase the storage amount. is that expected

@alexcreasy alexcreasy removed the lgtm label Nov 10, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 4ba8cfb into opendatahub-io:main Nov 10, 2023
6 checks passed
@DaoDaoNoCode
Copy link
Member Author

looks good. Just one question. if i create an unbound storage and then attach it to a workbench after creation. i still cant increase the storage amount. is that expected

@Gkrumbach07 This is decided by the cluster, if this is the behavior, then it is. We only catch the error and show it here but didn't change the behavior.

@Gkrumbach07
Copy link
Member

This is decided by the cluster, if this is the behavior, then it is. We only catch the error and show it here but didn't change the behavior.

sounds good
/lgtm

@Gkrumbach07 Gkrumbach07 mentioned this pull request Nov 10, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tracker]: DS Project vs OpenShift Projects
4 participants