-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge f/ds-projects to main #2118
Merge f/ds-projects to main #2118
Conversation
…ue-1417 Show non-DS projects in the project table
dry run and show error message on storage modal
…ue-1480 Support storage size unit and show error message correctly
…rd into f/ds-projects
…ue-2031 Add tests for project view
…rd into merge-f/ds-projects-to-main
Code looks good, tested and works aside from one small bug with filtering. @DaoDaoNoCode will create a ticket and raise a PR for the bug separately. Otherwise we are good to go to hit feature freeze. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexcreasy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
looks good. Just one question. if i create an unbound storage and then attach it to a workbench after creation. i still cant increase the storage amount. is that expected |
@Gkrumbach07 This is decided by the cluster, if this is the behavior, then it is. We only catch the error and show it here but didn't change the behavior. |
sounds good |
Closes #1924
Description
Add 2 new features:
How Has This Been Tested?
For data science projects page change:
For cluster storage change:
Test Impact
Added the integration test to verify it could correctly show the corresponding scope (DS projects or all projects).
Added unit tests to verify the filter function could filter out some system/default projects that we don't want to show.
Storage part tests not added because we need that for e2e tests, not for now.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main