Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment to global view and fix status #2121

Merged

Conversation

lucferbux
Copy link
Contributor

Description

Closes #1956

How Has This Been Tested?

No projects

  1. Delete all projects
  2. Go to model serving global
  3. Check that the No data science projects view is rendered
Screenshot 2023-11-10 at 17 12 26

Wrong project

  1. Go to model serving global
  2. Add to the URL modelServing/<path-to-wrong-object>
  3. Check that the Project not found image is rendered
Screenshot 2023-11-10 at 17 19 47

No models deploy in a new project

  1. Go to model serving global
  2. Select a newly create project with no serving platform selected
  3. Check that you get the "no deployed model" view
Screenshot 2023-11-10 at 17 23 14

Deploy a model in modelmesh

  1. Create a new project and select modelmesh as the serving platform
  2. Go to model serving global
  3. Click Deploy model
  4. Check that the modelmesh modal is shown
Screenshot 2023-11-10 at 17 11 09

Deploy a model in kserve

  1. Create a new project and select kserve as the serving platform
  2. Go to model serving global
  3. Click Deploy model
  4. Check that the modelmesh modal is shown
Screenshot 2023-11-10 at 17 10 44

List all resources

  1. Go to model serving global
  2. Check that you render all the resources
Screenshot 2023-11-10 at 17 10 15

Filter by project

  1. Go to model serving global
  2. Filter by project
  3. Check that only the right resources are rendered in the table
Screenshot 2023-11-10 at 17 10 23

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@lucferbux
Copy link
Contributor Author

@vconzola can you take a look at this please?

@lucferbux lucferbux force-pushed the issue-1956 branch 2 times, most recently from d9333ef to 406cca4 Compare November 10, 2023 16:39
@lucferbux lucferbux linked an issue Nov 10, 2023 that may be closed by this pull request
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Nov 10, 2023
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Peer coding with @lucferbux and running everything.

@lucferbux
Copy link
Contributor Author

/approve

Copy link
Contributor

openshift-ci bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaoDaoNoCode, lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8344e6d into opendatahub-io:f/model-serving Nov 10, 2023
4 checks passed
@vconzola
Copy link

@lucferbux A few comments...

  1. For the "No models deploy in a new project" scenario, is this behavior consistent with the way pipelines handles the same scenario? It should be.
  2. I think we need an additional empty state for the case where there the user has selected a serving platform for a project but hasn't deployed any models yet. We should show an empty state within the table with a deploy action button. (This might be handled automatically for our tables already?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Story]: Adapt Global Deploy Model Modal
4 participants