-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge Model Registry - Sidebar and EmptyState #2131
Edge Model Registry - Sidebar and EmptyState #2131
Conversation
@Sara4994 Make sure you fill out all the template information, including the checkboxes |
/hold waiting on tests |
waiting on tests, the rest looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@christianvogt can you give the final look at this to merge
for context this is just the feature flag and the first empty state for the edge feature
waiting on UX as well. @vconzola This is just for the navbar on the side and one empty state. The wording can change in future PRs if you dont have one now. This is just so we can start putting in a foundation for the architecture of the feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
c9b26e2
to
df3ec3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@Sara4994 After discussions with Gage and the RHOAI dashboard team I've updated the mockups, including the navigation and the empty state.
Mockups here: https://docs.google.com/presentation/d/1W9wHeASZsxz4W1UzyN-HfQCqeMhI0dm4IpyxnPBALLo/edit?usp=sharing Only the mockups with the red dots will be included for December. cc: @Gkrumbach07 |
df3ec3c
to
f6f3bfb
Compare
Thanks @vconzola for providing updated mockups. I have updated the UI as per the suggestions. please have a look if that looks good. |
@Sara4994 Can you update the screenshot in description, easy to review by UX. Also the linting test is failing. |
f6f3bfb
to
179ed07
Compare
/lgtm |
LGTM. |
179ed07
to
e32d3d0
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, dpanshug, Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
653b265
into
opendatahub-io:f/edge
Closes: #2061
Description
As part of new Edge specific initiatives, this PR introduces new section for Edge MVP and an empty state component on the new Model Registry page.
Its just the first step in Edge initiative and there will be more features introduced soon.
How Has This Been Tested?
Click Edge MVP option on the sidebar and select Model Registry
Test Impact
Integration Testing: Included simple test to check the title of EmptyState has rendered.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main