Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge Model Registry - Sidebar and EmptyState #2131

Conversation

Sara4994
Copy link

@Sara4994 Sara4994 commented Nov 13, 2023

Closes: #2061

Description

As part of new Edge specific initiatives, this PR introduces new section for Edge MVP and an empty state component on the new Model Registry page.

Its just the first step in Edge initiative and there will be more features introduced soon.

Screenshot 2023-11-22 at 5 30 01 PM

How Has This Been Tested?

Click Edge MVP option on the sidebar and select Model Registry

Test Impact

Integration Testing: Included simple test to check the title of EmptyState has rendered.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@Gkrumbach07
Copy link
Member

@Sara4994 Make sure you fill out all the template information, including the checkboxes

@Gkrumbach07
Copy link
Member

/hold waiting on tests

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Nov 14, 2023
frontend/src/app/AppRoutes.tsx Outdated Show resolved Hide resolved
frontend/src/utilities/NavData.tsx Outdated Show resolved Hide resolved
frontend/src/pages/edgeMVP/EdgeModelRegistry.tsx Outdated Show resolved Hide resolved
frontend/src/pages/edgeMVP/EdgeModelRegistry.tsx Outdated Show resolved Hide resolved
@Gkrumbach07
Copy link
Member

Gkrumbach07 commented Nov 16, 2023

waiting on tests, the rest looks good

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@christianvogt can you give the final look at this to merge

for context this is just the feature flag and the first empty state for the edge feature

@openshift-ci openshift-ci bot added the lgtm label Nov 16, 2023
@Gkrumbach07
Copy link
Member

waiting on UX as well.

@vconzola This is just for the navbar on the side and one empty state. The wording can change in future PRs if you dont have one now. This is just so we can start putting in a foundation for the architecture of the feature

@Gkrumbach07 Gkrumbach07 removed the do-not-merge/hold This PR is hold for some reason label Nov 16, 2023
frontend/src/pages/edge/EmptyModelRegistry.tsx Outdated Show resolved Hide resolved
frontend/src/pages/edge/EmptyModelRegistry.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@dpanshug dpanshug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 21, 2023
@Sara4994 Sara4994 force-pushed the sidebar-emptystates-components branch from c9b26e2 to df3ec3c Compare November 21, 2023 13:03
@openshift-ci openshift-ci bot removed the lgtm label Nov 21, 2023
Copy link
Contributor

@dpanshug dpanshug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 21, 2023
@vconzola
Copy link

@Sara4994 After discussions with Gage and the RHOAI dashboard team I've updated the mockups, including the navigation and the empty state.

  1. Edge will appear in the navigation above Settings and Resources
  2. We'll only have two subheadings under Edge - Models and ML Ops Pipelines (this second one might change)
  3. Text on the empty state has been updated. (Still not final, but close enough for now.)

Mockups here: https://docs.google.com/presentation/d/1W9wHeASZsxz4W1UzyN-HfQCqeMhI0dm4IpyxnPBALLo/edit?usp=sharing Only the mockups with the red dots will be included for December.

cc: @Gkrumbach07

@Sara4994 Sara4994 force-pushed the sidebar-emptystates-components branch from df3ec3c to f6f3bfb Compare November 22, 2023 11:12
@openshift-ci openshift-ci bot removed the lgtm label Nov 22, 2023
@Sara4994
Copy link
Author

Thanks @vconzola for providing updated mockups. I have updated the UI as per the suggestions. please have a look if that looks good.

@dpanshug
Copy link
Contributor

@Sara4994 Can you update the screenshot in description, easy to review by UX. Also the linting test is failing.

@Sara4994 Sara4994 force-pushed the sidebar-emptystates-components branch from f6f3bfb to 179ed07 Compare November 22, 2023 11:57
@dpanshug
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 22, 2023
@vconzola
Copy link

LGTM.

@Sara4994 Sara4994 force-pushed the sidebar-emptystates-components branch from 179ed07 to e32d3d0 Compare November 24, 2023 11:09
@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Nov 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, dpanshug, Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 653b265 into opendatahub-io:f/edge Nov 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants