Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change empty global model mesh serving link text to project display name #2133

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Change empty global model mesh serving link text to project display name #2133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/__tests__/integration/pages/modelServing/ModelServingGlobal.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ test('Empty State No Serving Runtime', async ({ page }) => {
await page.waitForSelector('text=No deployed models yet');

// Test that the button is enabled
await expect(page.getByRole('button', { name: 'Go to the Projects page' })).toBeTruthy();
await expect(page.getByRole('button', { name: 'Go to Test Project' })).toBeTruthy();
});

test('Empty State No Inference Service', async ({ page }) => {
Expand Down
7 changes: 3 additions & 4 deletions frontend/src/pages/modelServing/screens/global/EmptyModelServing.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import { getProjectModelServingPlatform } from '~/pages/modelServing/screens/pro
import { ServingRuntimePlatform } from '~/types';
import { byName, ProjectsContext } from '~/concepts/projects/ProjectsContext';
import useServingPlatformStatuses from '~/pages/modelServing/useServingPlatformStatuses';
import { getProjectDisplayName } from '~/pages/projects/utils';
import ServeModelButton from './ServeModelButton';

const EmptyModelServing: React.FC = () => {
Expand Down Expand Up @@ -47,11 +48,9 @@ const EmptyModelServing: React.FC = () => {
<EmptyStateSecondaryActions>
<Button
variant="link"
onClick={() =>
navigate(project?.metadata.name ? `/projects/${project.metadata.name}` : '/projects')
}
onClick={() => navigate(project ? `/projects/${project.metadata.name}` : '/projects')}
>
{project?.metadata.name ? `Go to ${project.metadata.name}` : 'Select a project'}
{project ? `Go to ${getProjectDisplayName(project)}` : 'Select a project'}
</Button>
</EmptyStateSecondaryActions>
</EmptyState>
Expand Down
Loading